Closed
Bug 941010
Opened 11 years ago
Closed 11 years ago
Catch error when checking for supported_languages
Categories
(Webmaker Graveyard :: Localization, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: sedge, Assigned: alicoding)
Details
Attachments
(1 file)
On https://github.com/mozilla/node-webmaker-i18n/blob/master/i18n.js#L231 the logic will fail if supported_languages doesn't exist.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #8335305 -
Flags: review?(kieran.sedgwick)
Reporter | ||
Updated•11 years ago
|
Attachment #8335305 -
Flags: review?(kieran.sedgwick) → review-
Assignee | ||
Updated•11 years ago
|
Attachment #8335305 -
Flags: review- → review?(kieran.sedgwick)
Reporter | ||
Comment 2•11 years ago
|
||
Comment on attachment 8335305 [details] [review] https://github.com/mozilla/node-webmaker-i18n/pull/22 1 nit - move this logic below the other variables being set, so the 1 line variable stuff is at the top.
Attachment #8335305 -
Flags: review?(kieran.sedgwick) → review+
Assignee | ||
Comment 3•11 years ago
|
||
merged https://github.com/alicoding/node-webmaker-i18n/commit/afcc8ac91350fffe6fa7f72f2b6d6a1031143c88
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•