revert patch 937006 once bug 937317 is landed

NEW
Unassigned

Status

()

Core
DOM: IndexedDB
P5
normal
5 years ago
4 months ago

People

(Reporter: baku, Unassigned)

Tracking

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

751 bytes, patch
Bobby Holley (On Leave Until June 11th)
: review-
Details | Diff | Splinter Review
Comment hidden (empty)
(Reporter)

Updated

5 years ago
Depends on: 937006
Component: DOM → DOM: IndexedDB
(Reporter)

Comment 1

5 years ago
Created attachment 8344165 [details] [diff] [review]
crash.patch

is it time to go back to MOZ_CRASH? bug  937317 is landed.
Attachment #8344165 - Flags: review?(bobbyholley+bmo)
Apparently not, since now it's backed out.
Comment on attachment 8344165 [details] [diff] [review]
crash.patch

Hm. nsJSUtils::GetCallingLocation doesn't look at the Script Setting Stack, so this patch isn't correct on its own.

But this raises an interesting question of what, if anything, we want to happen here. The Script Settings Stack tracks incumbent globals, so that, when a non-scripted callback fires, we know which global it belongs to. And while globals generally have an origin and whatnot, that origin doesn't necessarily correspond with script filename (in the case of external scripts). And it certainly doesn't help us for line numbers.

So if we want a true (filename, line number) tuple here, I was mistaken that this would be resolved by the script settings stack, and we should WONTFIX this bug. But if it's more important to just get _something_, then we could grab the principal URI off the incumbent global (and report 0 for the line number, or something).

I suspect the answer here is probably WONTFIX. Thoughts?
Attachment #8344165 - Flags: review?(bobbyholley+bmo) → review-
Something is always better than nothing.

Updated

4 months ago
Priority: -- → P5
You need to log in before you can comment on or make changes to this bug.