941075 - Case sensitivity issues with default_locale leads to nameless app

Status: VERIFIED FIXED

(Marketplace Graveyard :: Validation, defect, P2)

Description

[Mathieu Pillard [:mat]]

- Submit an hosted app with a default_locale of "PT-br" and no other specific locales stuff (see http://brokenptbr.testmanifest.com/ )
- Observe that you get a nameless app and that the default_locale isn't saved properly (it's set to your current language, the one you used on the Marketplace when you submitted the app).

Comment 1

[Andy McKay]

We should be validating those locales, seeing if they are legit.

Comment 3

[Mathieu Pillard [:mat]]

FYI : when Krupa filed the duplicate, bug 1080307, it was already fixed on stage because of the changes from bug 1074363. So this bug will be "fixed" in tomorrow's push. However, this is brittle, so I'm adding tests and making sure we don't accept broken locales like that:
https://github.com/mozilla/zamboni/pull/2656
https://github.com/mozilla/app-validator/pull/37

Comment 4

[Mathieu Pillard [:mat]]

Decided to stay simple for now and not refuse broken locales in the validator, but fix them in zamboni.

So https://github.com/mozilla/zamboni/commit/3016cc9fbee462cb4a043324288ee161c87541d3 and https://github.com/mozilla/zamboni/commit/9cac9f9d3bbfcc31978b1aeab1b34e35baf1052b fix this bug, they were already merged.

Comment 5

[Madalin Cotetiu]

Verified as fixed in FF35(Win7) in marketplace-dev.allizom.org
I have tested with both hosted and packaged apps, with valid and broken locales. For each case the localization is saved correctly and displayed right in edit listing page.
Screencasts: http://screencast.com/t/1iS0Oj2fN    http://screencast.com/t/mrjb6nk9G
Closing.