Closed Bug 941090 Opened 7 years ago Closed 7 years ago

build (some of) gfx/ots in unified mode

Categories

(Core :: Graphics: Text, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: jfkthame, Assigned: jfkthame)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

Looks like we can build a fair bit of OTS this way, but there are a handful of files that all use the same macro name (but with separate, file-specific definitions). So I'm excluding those.

We could patch the sources to avoid the issue (e.g. by adding an #undef at the end of each such file), but as this is imported code I'm reluctant to add a local patch just for the slight benefit that would give. (There are a couple other issues we'd also have to patch if we did that, too.)
Attachment #8335392 - Flags: review?(ehsan)
Comment on attachment 8335392 [details] [diff] [review]
build ots in unified mode, except the files that define a table-specific DROP_THIS_TABLE macro

Review of attachment 8335392 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, we don't want to go too crazy with imported code. :-)
Attachment #8335392 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/mozilla-central/rev/ea7e3169f3ff
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.