941119 - Add/Update reviewer canned responses about China queue

Status: RESOLVED WONTFIX

(Marketplace Graveyard :: Reviewer Tools, defect)

Description

[krupa raj[:krupa]]

We have canned responses which reviewers can use during approving an app. These canned responses needs to be updated to include information about the China queue

a) Approved: We need to add a line about the app now being eligible for a China review which may take a few days.

b) Rejected for China: Add a canned response which soothes the nerves of the developers drowning in the misery of their app being rejected from China.

Comment 1

[Andrew Williamson [:eviljeff]]

While I don't know anything about the China Review process/policy (thats for the China review team people to determine) I would have thought there wouldn't be any overlap so the canned responses would be entirely different for that review.

bug 940111 should probably be updated to specify a canned responses drop-down.

We (Lisa or myself) can assist in actually adding the canned responses in the admin section once the China guys decide what they are.

Comment 2

[krupa raj[:krupa]]

The idea was to append the canned response for App approvals and adding a new canned response specifically for china rejections.

Comment 3

[Andrew Williamson [:eviljeff]]

(In reply to krupa raj[:krupa] from comment #2)
> The idea was to append the canned response for App approvals 

that seems difficult to determine in a canned response - the developer may or may not have selected China review and the reviewer would have no way of knowing.  If such a message is required it should be in the email template instead so it can be shown only if the developer has requested it.

> and adding a new canned response specifically for china rejections.

the china queue doesn't use the standard review form so unless a canned response dropdown is being added in bug 940111 then no.

Comment 4

[Davor Spasovski [:spasovski]]

Does this still need developer attention?

Comment 5

[Andrew Williamson [:eviljeff]]

(In reply to Davor Spasovski [:spasovski] from comment #4)
> Does this still need developer attention?

if the needs krupa identified are still valid yes.  As per comment #3 though, the approval note should be in the email template code so it can be only included if the developer has selected China Approval; and if a rejection canned response is wanted then a canned response dropdown needs to be added to that China review queue page (I didn't see one last time I looked)