Stop running make check twice in js/src

RESOLVED FIXED in mozilla28

Status

RESOLVED FIXED
5 years ago
6 months ago

People

(Reporter: ted, Assigned: ted)

Tracking

unspecified
mozilla28

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [capacity])

Attachments

(1 attachment)

Apparently we've been running "make check" twice in js/src for a while. I suspect this is a regression from bug 910096, on top of the workaround from bug 847369.

This patch basically just removes the workaround here:
http://hg.mozilla.org/mozilla-central/file/597287004ff5/Makefile.in#l259
Created attachment 8335433 [details] [diff] [review]
Stop running make check twice in js/src
Attachment #8335433 - Flags: review?(gps)
Blocks: 910096
Whiteboard: [capacity]

Updated

5 years ago
Attachment #8335433 - Flags: review?(gps) → review+
The Try push showed it running "make check" only once in js/src, as expected, and only one invocation of jit_test.py.
(Props to catlee for pointing out the source link in comment 0, good catch!)
https://hg.mozilla.org/mozilla-central/rev/1e0009c38c50
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28

Updated

6 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.