941142 - APN panel checkbuttons are misaligned

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Eitan Isaacson [:eeejay]]

This is also happening in the APN panels under Cell and data panel. :(

Comment 1

[Jason Smith [:jsmith]]

Can you provide a screenshot? I'm wondering how bad this is.

Comment 2

[Eitan Isaacson [:eeejay]]

Could you provide a screenshot and steps to reproduce? I can't find this issue.

Comment 3

[José Antonio Olivera Ortega [:jaoo]]

Attachment: screenshot.png

(In reply to Eitan Isaacson [:eeejay] from comment #2)
> Could you provide a screenshot and steps to reproduce? I can't find this
> issue.

Sure. FYI this is happening on peak device. I've not testes on unagi or buri devices.

Comment 4

[Eitan Isaacson [:eeejay]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13919

Pointer to Github pull-request

Comment 5

[Eitan Isaacson [:eeejay]]

Comment on attachment 8336206 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13919

Hey Josea, I think this will fix the issue. Could you confirm?

Comment 6

[José Antonio Olivera Ortega [:jaoo]]

Attachment: 2013-11-21-13-37-10.png

(In reply to Eitan Isaacson [:eeejay] from comment #5)
> Comment on attachment 8336206 [details]
> Pointer to Github pull request:
> https://github.com/mozilla-b2g/gaia/pull/13919
> 
> Hey Josea, I think this will fix the issue. Could you confirm?

Fixed, thanks!

Comment 7

[Eitan Isaacson [:eeejay]]

Comment on attachment 8336206 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13919

Thanks for the feedback!

Comment 8

[Fabien Cazenave [:kaze]]

Comment on attachment 8336206 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13919

Another good catch.

Comment 9

[Eitan Isaacson [:eeejay]]

https://github.com/mozilla-b2g/gaia/commit/477adf7702246476b4de4bb3168ea651b76cd161