941187 - Jplayer audio not detecting native supported media

Status: RESOLVED DUPLICATE of bug 887517

(Web Compatibility :: Site Reports, defect)

Description

[Rob Voyle]

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:25.0) Gecko/20100101 Firefox/25.0 (Beta/Release)
Build ID: 20131112160018

Steps to reproduce:

Jplayer audio wont' work: see
http://www.appreciativeway.com/hope/test.cfm

The player link "Listen to child of the angels" gives default "plugin required"

Researched with members of jplayer community, updated all components still won't work


Actual results:

get the default plugin required but there is no flash plugin in for Firefox


Expected results:

The recording should play as it does on Windows Firefox, or as it does on the Samsung default browser

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

This strikes me as a bug in JPlayer. Firefox for Android can play mp3 files without Flash. Visiting the file directly shows this http://www.appreciativeway.com/hope/childOfTheAngels-MJessen.mp3

Comment 2

[Aaron Train [:aaronmt]]

E/GeckoConsole( 4854): [JavaScript Error: "TypeError: document.getElementById(...) is null" {file: "http://www.appreciativeway.com/hope/test.cfm?audioToPlay=childOfTheAngels-MJessen.mp3" line: 42}]


http://www.appreciativeway.com/jplayer/jquery.jplayer.min.js

The site is using jQuery jPlayer 2.5.0

Halvord/Karl/Mike, is this a known issue with jPlayer?

https://github.com/happyworm/jPlayer/blob/master/jquery.jplayer/jquery.jplayer.js#L249

Can we identify where their detection fails exactly (we can natively play media but they are prompting for either an updated browser and Flash required)?

Comment 3

[Mike Taylor [:miketaylr]]

I'm interested specifically in https://github.com/happyworm/jPlayer/blob/master/jquery.jplayer/jquery.jplayer.js#L935-L941. `document.querySelector('audio')` returns null, so that seems to hint that the `this.html.audio.available` test is failing.

Will need to wait until I'm back at my house to debug with the unminifed source over a proxy.

Comment 4

[Mike Taylor [:miketaylr]]

OK, think I have this figured out. They're not doing any kind of UA sniffing to determine Flash vs. HTML5 audio AFAICT (they're using that to determine platform features like volume/fullscreen).

They do a test to determine mp3 support like so: `$.jPlayer.focus.htmlElement.audio.canPlayType('audio/mpeg; codecs="mp3"')` which returns `""`... which looks like Bug #887517.

Comment 5

[Mike Taylor [:miketaylr]]

(to be more clear, I ran that in the console of http://jplayer.org/latest/demo-01-supplied-mp3/, which demonstrates the same problem)

Comment 6

[Mike Taylor [:miketaylr]]

Just confirmed by removing the codec part from https://github.com/happyworm/jPlayer/blob/master/jquery.jplayer/jquery.jplayer.js#L689 and then the audio plays on Firefox for Android (w/o Flash prompt).

Comment 7

[Mark Panaghiston]

Yes, jPlayer feature checks for support using the mediaElement.canPlayType(mime) method.

I have been considering an addition to jPlayer, which dumbs down the whole canPlayType(), where we test for a range of types... Starting with the codecs being given and going down to "audio/mpeg" in a loop.

There was no sensible way for feature detecting for whether the volume controls had any effect, which is why we added the UA check for the platforms.

A side point: In many browsers the codec part seems to be pointless. Some will even say "probably" to a codec=rubbish while saying maybe without the codec part.

Comment 8

[Mark Panaghiston]

Since it might be of use... The problem was originally investigated by Rob and me here:
https://groups.google.com/d/topic/jplayer/apiPxAdK-Zs/discussion

Comment 9

[Hallvord R. M. Steen [:hallvors]]

Mark: thanks for contributing :)

Everyone: I don't think this is a valid evangelism issue - it's just a core bug, no? Can't we just close it as a dup?

Comment 10

[Mike Taylor [:miketaylr]]

Yeah, let's close it as a dupe of 887517. Once that's fixed the problematic site will just work.™