Closed
Bug 941220
Opened 11 years ago
Closed 11 years ago
Call GetVisualOverflowRectRelativeToSelf() once instead of three times in nsIFrame::BuildDisplayListForStackingContext
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)
Details
(Keywords: perf, Whiteboard: [qa-])
Attachments
(2 files)
|
3.03 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
|
1.14 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
http://hg.mozilla.org/mozilla-central/annotate/7c730b25a3df/layout/generic/nsFrame.cpp#l1814 calls GetVisualOverflowRectRelativeToSelf() three times in the worst case, on line 1824, 1834 and 1838. (found while analyzing the SVG perf problem in in bug 931422) https://tbpl.mozilla.org/?tree=Try&rev=ec0b0c20db53
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8337059 -
Flags: review?(roc)
Attachment #8337059 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 2•11 years ago
|
||
Sorry to bother you again but I realized there's no point in clearing 'dirtyRect' in case we're returning. (I'll fold this into the first part before landing.)
Attachment #8337261 -
Flags: review?(roc)
Attachment #8337261 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/9d4fbec564ab
Flags: in-testsuite-
|
||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9d4fbec564ab
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
|
||
Updated•10 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•