Call GetVisualOverflowRectRelativeToSelf() once instead of three times in nsIFrame::BuildDisplayListForStackingContext

RESOLVED FIXED in mozilla28

Status

()

Core
Layout
--
minor
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: mats, Assigned: mats)

Tracking

({perf})

unspecified
mozilla28
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(2 attachments)

(Assignee)

Description

4 years ago
http://hg.mozilla.org/mozilla-central/annotate/7c730b25a3df/layout/generic/nsFrame.cpp#l1814
calls GetVisualOverflowRectRelativeToSelf() three times in the worst case,
on line 1824, 1834 and 1838.

(found while analyzing the SVG perf problem in in bug 931422)

https://tbpl.mozilla.org/?tree=Try&rev=ec0b0c20db53
(Assignee)

Comment 1

4 years ago
Created attachment 8337059 [details] [diff] [review]
fix
Attachment #8337059 - Flags: review?(roc)
Attachment #8337059 - Flags: review?(roc) → review+
(Assignee)

Comment 2

4 years ago
Created attachment 8337261 [details] [diff] [review]
part 2

Sorry to bother you again but I realized there's no point in clearing
'dirtyRect' in case we're returning.  (I'll fold this into the first
part before landing.)
Attachment #8337261 - Flags: review?(roc)
Attachment #8337261 - Flags: review?(roc) → review+
(Assignee)

Comment 3

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/9d4fbec564ab
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/9d4fbec564ab
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28

Updated

4 years ago
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.