mach build does not find dependency through xpcshell.ini include: feature

NEW
Unassigned

Status

P3
normal
5 years ago
9 months ago

People

(Reporter: Irving, Unassigned)

Tracking

(Blocks: 1 bug)

Trunk
x86
Mac OS X
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

http://dxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/test/xpcshell/xpcshell.ini

uses the xpcshell.ini [include:<filename>] feature to include

http://dxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/test/xpcshell/xpcshell-shared.ini

I made a change to xpcshell-shared.ini, but the change was not picked up by 'mach build' (either at the top level, or 'mach build toolkit/mozapps/extensions') until I also touched xpcshell.ini

This appears to be the only place in the tree we use the [include:<filename>] feature, so a special case solution would be fine with me.
Blocks: 941904
Ted: Did you encounter any more funky [include] usage as part of porting mochitests? Just trying to assign a priority to this. I don't think we've hit this in the wild in 3 months, so I'm tempted to keep it low priority.
Flags: needinfo?(ted)
Priority: -- → P3
We don't really use this anywhere in our other manifests:
http://mxr.mozilla.org/mozilla-central/search?string=[include&find=\.ini%24&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

I did notice one issue that we are actually going to need to fix, it's probably related:
http://hg.mozilla.org/mozilla-central/annotate/d2dac18d0562/python/mozbuild/mozbuild/frontend/emitter.py#l561

We don't even install included manifests into the objdir, AFAICT. You apparently worked around this in one manifest by sticking the included manifest in support-files:
http://hg.mozilla.org/mozilla-central/annotate/d2dac18d0562/toolkit/mozapps/extensions/test/xpcshell/xpcshell.ini#l8
Flags: needinfo?(ted)
I think bug 938019 will magically resolve this issue (or at least bring us a step closer to the proper solution).
Depends on: 938019

Updated

9 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.