941319 - mach build does not find dependency through xpcshell.ini include: feature

Status: NEW

(Firefox Build System :: General, defect, P3)

Description

[:Irving Reid (No longer working on Firefox)]

http://dxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/test/xpcshell/xpcshell.ini

uses the xpcshell.ini [include:<filename>] feature to include

http://dxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/test/xpcshell/xpcshell-shared.ini

I made a change to xpcshell-shared.ini, but the change was not picked up by 'mach build' (either at the top level, or 'mach build toolkit/mozapps/extensions') until I also touched xpcshell.ini

This appears to be the only place in the tree we use the [include:<filename>] feature, so a special case solution would be fine with me.

Comment 1

[Gregory Szorc [:gps]]

Ted: Did you encounter any more funky [include] usage as part of porting mochitests? Just trying to assign a priority to this. I don't think we've hit this in the wild in 3 months, so I'm tempted to keep it low priority.

Comment 2

[(not currently active) Ted Mielczarek]

We don't really use this anywhere in our other manifests:
http://mxr.mozilla.org/mozilla-central/search?string=[include&find=\.ini%24&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

I did notice one issue that we are actually going to need to fix, it's probably related:
http://hg.mozilla.org/mozilla-central/annotate/d2dac18d0562/python/mozbuild/mozbuild/frontend/emitter.py#l561

We don't even install included manifests into the objdir, AFAICT. You apparently worked around this in one manifest by sticking the included manifest in support-files:
http://hg.mozilla.org/mozilla-central/annotate/d2dac18d0562/toolkit/mozapps/extensions/test/xpcshell/xpcshell.ini#l8

Comment 3

[Gregory Szorc [:gps]]

I think bug 938019 will magically resolve this issue (or at least bring us a step closer to the proper solution).