Closed Bug 941331 Opened 6 years ago Closed 6 years ago

Double-tap zoom should include a margin around the tapped element

Categories

(Firefox for Metro Graveyard :: Pan and Zoom, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 28

People

(Reporter: mbrubeck, Assigned: mbrubeck)

References

Details

Attachments

(1 file)

When zooming into a block of text, it's easier to read the text if it doesn't extend all the way to the edge of the screen, but instead has a small margin around it -- maybe 16px added to each side of the rectangle.
Summary: Double-tap zoom should include a margin around the tapped element → Change - Double-tap zoom should include a margin around the tapped element
Whiteboard: [triage] feature=change c=tbd u=tbd p=0
Attached patch patchSplinter Review
Assignee: nobody → mbrubeck
Status: NEW → ASSIGNED
Attachment #8335721 - Flags: review?(ally)
No longer blocks: metrov1backlog
Summary: Change - Double-tap zoom should include a margin around the tapped element → Double-tap zoom should include a margin around the tapped element
Whiteboard: [triage] feature=change c=tbd u=tbd p=0
Just 16 pixels? I think we should be much more subtle - maybe 10% of the view width or height, whichever is smaller? It feels like we are too aggressive in our zoom in.
(In reply to Jim Mathies [:jimm] from comment #2)
> Just 16 pixels? I think we should be much more subtle - maybe 10% of the
> view width or height, whichever is smaller? It feels like we are too
> aggressive in our zoom in.

The downside of making the margin much larger is that, instead of seeing just the element you tapped, you get other elements peeeking in at the edges of the screen -- ads and navigation bars in particular.

Note that this is 16px in page coordinates, not screen coordinates.  If you are zoomed in to 2x scale, then those "16px" will be 32px (1/3") on screen.  On a high-dpi screen (1.8dppx), that's a margin of 58 device pixels on each side.
Comment on attachment 8335721 [details] [diff] [review]
patch

Review of attachment 8335721 [details] [diff] [review]:
-----------------------------------------------------------------

nit: Please stick the '16' in a const, maybe at the top of the file. Jimm, we can tune that margin as needed.
Attachment #8335721 - Flags: review?(ally) → review+
(In reply to :Ally Naaktgeboren from comment #4)
> nit: Please stick the '16' in a const, maybe at the top of the file.

Fixed:
https://hg.mozilla.org/integration/fx-team/rev/5c11b81a0c91
https://hg.mozilla.org/mozilla-central/rev/5c11b81a0c91
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 28
You need to log in before you can comment on or make changes to this bug.