941337 - Handle deleted apps inside collections

Status: VERIFIED FIXED

(Marketplace Graveyard :: API, defect, P1)

Description

[sdevaney]

Attachment: oh_noes.png

See attached image. I receive an error message in the curation tool when I try to update Featured Apps on the Games page for Worldwide. This is the only page this occurs, as I just went through all Worldwide and region-specific Home and Game pages to update programming. 

Log: 602a8

Comment 1

[Matt Basta [:basta]]

Looks like a 500 on the rocketfuel endpoints:

[req] GETing https://marketplace.firefox.com/api/v1/rocketfuel/collections/?_user=---&carrier&cat=games&region=worldwide
...
[req] Request failed: GET 500


There should be something in sentry.

Comment 2

[Mathieu Pillard [:mat]]

I don't see anything in Sentry, can you still reproduce ?

Comment 3

[sdevaney]

I still got the error message this morning.

Log: 18701

Comment 4

[sdevaney]

Any updates? This error is still in effect? Thanks.

Comment 5

[sdevaney]

Now I'm getting the same error message for region: Serbia ... category: Social

Log ac078

Comment 6

[Mathieu Pillard [:mat]]

Looks like this is http://sentry.mktmon.services.phx1.mozilla.com/mkt/marketplacefirefoxcom/group/2472/

Comment 7

[Mathieu Pillard [:mat]]

So, the collection you are seeing here contains an app that is deleted. Somehow this app is kept in the collection, and when we try to return it as part of the result, boom. I'll fix this.

Comment 8

[Mathieu Pillard [:mat]]

Fixed in https://github.com/mozilla/zamboni/commit/ccab9c07c3b0aa7379a8207b49d8e1e25bf182b7

STR:
- Add a couple apps to a featured apps collection in the curation tool
- Go the developer pages and delete one of the app you added to the collection
- Go back to the curation tool, the collection should show up fine, with only the other app in it
- In the consumer pages, set your region to the one corresponding to your collection using :debug, and then go the corresponding category. The featured apps collection should show up, and it shouldn't show the deleted app
- Repeat from the beginning with disabling an app instead of just deleting it. Re-enabling the app should make it show up.

Comment 9

[Victor Carciu]

Verified as fixed for both delete and disable scenarios.

Comment 10

[sdevaney]

Apologies for my lack of technical acumen, but I've re-opened this bug because I am still seeing this error in the curation tool. As the programmer of featured content, I'm unsure how to proceed. Thanks.

Comment 11

[Chuck Harmston [:chuck]]

I imagine that there's some bad data left in the database. If Mathieu doesn't beat me to it, I'll try to get this taken care of before the start of the PST workday on Monday.

Comment 12

[Mathieu Pillard [:mat]]

The fix will only go in production next tuesday.

Comment 13

[sdevaney]

OK thanks. It looks like this bug is affecting all Social pages with the exception of Poland. The timing is unfortunate as we just got the popular messaging app MessageMe and it would be great to feature it on Social pages in all regions. Thanks again for your attention to this, guys!

Comment 14

[Mathieu Pillard [:mat]]

Re-open if this is still a problem after tuesday push (should be noon PST)

Comment 15

[Victor Carciu]

Verified as fixed based on comment #9 . Re-open only if it is reproducible after push(described by Mathieu in comment #14)