Closed Bug 94135 Opened 23 years ago Closed 23 years ago

nsPrefBranch::SetComplexValue : rv may be returned uninitialized.

Categories

(Core :: Preferences: Backend, defect)

Product:
Core
Component:
Preferences: Backend
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: mozilla-bugs, Assigned: bnesse)

References

(
URL
)

Details

If theString is NULL on line 394 of nsPrefBranch.cpp, the
nsPrefBranch::SetComplexValue will return an uninitialized rv. It should return
an appropriate error value instead.
Yes, and there are other cases which need to handle his as well. See also bug
49776 which pertains to character prefs. I really need to whip up a patch which
covers all the sanity checking cases.
Status: NEW → ASSIGNED
Blocks: 59652
Depends on: 49776
I have marked this as blocked by bug 49776 as I am fixing this in that patch,
which is doing a fairly widespread bulletproofing of the prefs code.
Fixed by the bulletproofing checkin for Bug 49776.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
rubberstamp
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.