941397 - Progress message on Firefox Stub install for Japanese and other languages that don't break words with spaces.

Status: VERIFIED FIXED

(Firefox :: Installer, defect)

Description

[Makoto Kato [:m_kato]]

Attachment: IMG 2013-11-21 11.19.31.png

When using JPN version of Stub installer from https://ftp.mozilla.org/pub/mozilla.org/firefox/releases/25.0/win32/ja/Firefox%20Setup%20Stub%2025.0.exe, the haiku? message on progress dialog seems to be out of screen.  But when using ENG version, no problem.

See screenshot.

Comment 1

[Robert Strong (they/them - no direct email)]

I tested Japanese when I wrote the stub installer and it worked then. Could you check older versions of the Japanese stub installer to see if it reproduces with them as well? Thanks

Comment 2

[Makoto Kato [:m_kato]]

(In reply to Robert Strong [:rstrong] (do not email) from comment #1)
> I tested Japanese when I wrote the stub installer and it worked then. Could
> you check older versions of the Japanese stub installer to see if it
> reproduces with them as well? Thanks

I test using Firefox Setup Stub 24.0.exe from http://ftp.mozilla.org/pub/mozilla.org/firefox/releases/24.0/win32/ja/, same issue occurs too.

Screenshot is on windows 7 JPN, but I can reproduce on Windows 8.1 JPN

Comment 3

[Robert Strong (they/them - no direct email)]

I'm a tad surprised that this wasn't reported previously. Do you have a second Win 7 JPN system that you can test on so the possibility that it is system specific can be lessened?

Comment 4

[Brian R. Bondy [:bbondy]]

maybe dpi related?

Comment 5

[Makoto Kato [:m_kato]]

(In reply to Robert Strong [:rstrong] (do not email) from comment #3)
> I'm a tad surprised that this wasn't reported previously. Do you have a
> second Win 7 JPN system that you can test on so the possibility that it is
> system specific can be lessened?

Mozilla Japan web site doesn't offer stub installer, so anyone cannot hit this issue.

Also, although I test JPN stub installer on Windows 8 US verison, this problem occurs this.

(In reply to Brian R. Bondy [:bbondy] from comment #4)
> maybe dpi related?

No. I use DPI is 100%.

Comment 6

[Makoto Kato [:m_kato]]

http://www.mozilla.jp/firefox/ always offers full installer, not stub installer

Comment 7

[Makoto Kato [:m_kato]]

In Japanese locale for stub is here. https://hg.mozilla.org/l10n-central/ja/file/151d7fb11e83/browser/installer/nsisstrings.properties

INSTALL_BLURB3 in JA properties has no "\n" and space, all string maybe one line...

Comment 8

[Robert Strong (they/them - no direct email)]

Does this only happen with INSTALL_BLURB3 and the first two display correctly?

Comment 9

[Robert Strong (they/them - no direct email)]

Note: the en-US version overrides the following so it displays the haiku
http://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/installer/nsisstrings.properties#26

The override has "\n" so each section of the haiku is on a newline otherwise it just wraps the text.
http://mxr.mozilla.org/mozilla-central/source/browser/installer/windows/nsis/stub.nsi#263

Comment 10

[Makoto Kato [:m_kato]]

(In reply to Robert Strong [:rstrong] (do not email) from comment #8)
> Does this only happen with INSTALL_BLURB3 and the first two display
> correctly?

No. INSTALL_BLURB2 in JA is pretty long too, so position is wrong.

If INSTALL_BLURBx has lone sentence that has no "\n" and space, this problem seems to occur.

Comment 11

[Robert Strong (they/them - no direct email)]

Thanks m_kato! I was able to reproduce and should be able to figure this out.

Comment 12

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1 - remove DT_NOFULLWIDTHCHARBREAK flag

I misunderstood the behavior of the DT_NOFULLWIDTHCHARBREAK flag and thought it behaved differently when combined with the DT_WORDBREAK... meh!

Comment 13

[Robert Strong (they/them - no direct email)]

Attachment: patch - remove DT_NOFULLWIDTHCHARBREAK flag

Forgot to comment out the STUB_DEBUG define

Comment 14

[Robert Strong (they/them - no direct email)]

Pushed to fx-team
https://hg.mozilla.org/integration/fx-team/rev/a1d6c5cd7b2d

Comment 15

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/a1d6c5cd7b2d

Comment 16

[Robert Strong (they/them - no direct email)]

Comment on attachment 8336652 [details] [diff] [review]
patch - remove DT_NOFULLWIDTHCHARBREAK flag

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 322206 which implemented the stub installer
User impact if declined: at minimum the ja, zh-TW, and zh-CN locales will not display the marketing blurbs correctly during the downloading and installation phase when installing from the stub installer.
Testing completed (on m-c, etc.): Manually tested using latest nightly and using a local build using the strings from the ja locale
Risk to taking this patch (and alternatives if risky): minimal.
String or IDL/UUID changes made by this patch: None

Note: since this only affects certain localized builds which aren't well tested (hence why this is only being reported now) I'd like to get this uplifted to branches so the change is tested and so users don't experience this bug which might make them cancel the installation.

Comment 17

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 8336652 [details] [diff] [review]
patch - remove DT_NOFULLWIDTHCHARBREAK flag

Let's get testing around this before release.

Comment 18

[Lukas Blakk [:lsblakk] use ?needinfo]

Juan can you put this at the top of your testing for 26.0b8 ?

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/fd75c8f6cc7d
https://hg.mozilla.org/releases/mozilla-beta/rev/070d5dcee33d

Comment 20

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/070d5dcee33d

Comment 21

[Bogdan Maris, Desktop QA]

Mozilla/5.0 (Windows NT 6.3; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0

Verified as fixed on Windows 8.1 x64 using Firefox 26 beta 8 (buildID: 20131125215016).

Comment 22

[juan becerra [:juanb]]

While looking at this, I tried a few other locales like ar, el, and he, and I found that the "he" stub installer wasn't localized. I filed bug 943634 for that separate issue.

Comment 23

[Bogdan Maris, Desktop QA]

Verified as fixed on Windows 8.1 x64 using latest Aurora (ja/zh-CN/zh-TW/ar/el builds).

Comment 24

[Bogdan Maris, Desktop QA]

Also verified as fixed on Windows 8.1 x64 using latest Aurora 28.0a2 (buildID: 2013121100400)
 - Verified with ja/ja-JP/zh-CN/zh-TW/ar/el/ru/xh builds.