941405 - Make XPCOM slower

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[(no longer active)]

I'm planning to remove some of the usages of the register keyword from XPCOM to make it slower.  ;-)

Comment 1

[(no longer active)]

Attachment: Remove the usages of the register keyword from XPCOM; r=froydnj

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8335791 [details] [diff] [review]
Remove the usages of the register keyword from XPCOM; r=froydnj

Review of attachment 8335791 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with a strong suggestion that you run all talos suites to confirm that you're not going to regress performance. :)

Comment 3

[Andrew McCreight [:mccr8]]

Out of curiosity, what does removing these buy you?

Comment 4

[(no longer active)]

(In reply to Andrew McCreight [:mccr8] from comment #3)
> Out of curiosity, what does removing these buy you?

Fewer compiler warnings telling me that `register' is meaningless, slowly sucking the joy out of my new awesome fast builds.

Comment 5

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6735160dc842

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6735160dc842