Status

()

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

Trunk
mozilla28
x86
Mac OS X
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
I'm planning to remove some of the usages of the register keyword from XPCOM to make it slower.  ;-)
(Assignee)

Comment 1

5 years ago
Created attachment 8335791 [details] [diff] [review]
Remove the usages of the register keyword from XPCOM; r=froydnj
(Assignee)

Updated

5 years ago
Attachment #8335791 - Flags: review?(nfroyd)
Comment on attachment 8335791 [details] [diff] [review]
Remove the usages of the register keyword from XPCOM; r=froydnj

Review of attachment 8335791 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with a strong suggestion that you run all talos suites to confirm that you're not going to regress performance. :)
Attachment #8335791 - Flags: review?(nfroyd) → review+
Out of curiosity, what does removing these buy you?
(Assignee)

Comment 4

5 years ago
(In reply to Andrew McCreight [:mccr8] from comment #3)
> Out of curiosity, what does removing these buy you?

Fewer compiler warnings telling me that `register' is meaningless, slowly sucking the joy out of my new awesome fast builds.
https://hg.mozilla.org/mozilla-central/rev/6735160dc842
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
You need to log in before you can comment on or make changes to this bug.