941440 - The layout of Macedonian keyboard is incorrect - the space key is too small

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: Macedonian keyboard layout

STR
===
1. Use this command to add Macedonian (mk) keyboard
 > GAIA_KEYBOARD_LAYOUTS=en,pt-BR,es,de,fr,pl,mk make reset-gaia

2. Enable it from settings > keyboards

3. Launch the keyboard

Expected: the layout looks normal
Actual result: the layout looks strange, the space is too small that makes the last row not well aligned, see the attached screenshot.

--
Gaia rev.: 239ed2386cf5f6b0a22320294cb4105ec7333be1

Comment 1

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: Patch V1 - pull request 13892

This is a one-line patch to fix the ratio of the space key in Macedonian keyboard layout.

Tim, could you help review this?
Thanks.

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8335834 [details] [review]
Patch V1 - pull request 13892

rubber-stamp if you have visually inspect the patch.

Comment 3

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Gaia master,
https://github.com/mozilla-b2g/gaia/commit/d04ccfacdaf820b888f613dcae9a40d7e2a88f7e

v1.2,
https://github.com/mozilla-b2g/gaia/commit/0c0de9c7611de6e445a1c1d00d557cb0b26d9b37

--
Thanks.