Closed Bug 941450 Opened 6 years ago Closed 6 years ago

Define some class of generated files in moz.build

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla28

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

We have a bunch of foo.$(OBJ_SUFFIX): some-generated-file dependencies in the tree.

They are error-prone (both in the fact that some-generated-file might just have been added as an include to another file unnoticedly, and in the fact that it breaks UNIFIED_SOURCES in subtle ways), and useless half of the time (those dependencies are generated by the compiler for incremental builds). The other half of the time, it's a clobber build, in which case we can just enforce the build order at the build system level.
Blocks: 939608
Blocks: 939585
Comment on attachment 8335838 [details] [diff] [review]
Add some GENERATED_FILES to moz.build

Review of attachment 8335838 [details] [diff] [review]:
-----------------------------------------------------------------

Lovely holdover until we express codegen in moz.build.
Attachment #8335838 - Flags: review?(gps) → review+
Blocks: 883954
I pushed this to try along since its blocking my queue, but no need to wait if you don't need try:
https://tbpl.mozilla.org/?tree=Try&rev=bd61ddee653a
https://hg.mozilla.org/mozilla-central/rev/c30371a66429
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
https://hg.mozilla.org/mozilla-central/rev/ed85b703a939
Status: REOPENED → RESOLVED
Closed: 6 years ago6 years ago
Resolution: --- → FIXED
Depends on: 1162846
Depends on: 1162847
No longer depends on: 1162846
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.