Closed
Bug 941506
Opened 12 years ago
Closed 12 years ago
Output a message on tbpl summary box when autoclobbering
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla28
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file)
|
1.14 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
No description provided.
| Assignee | ||
Comment 1•12 years ago
|
||
Attachment #8335907 -
Flags: review?(gps)
Comment 2•12 years ago
|
||
Good idea - thank you :-)
Comment 3•12 years ago
|
||
Comment on attachment 8335907 [details] [diff] [review]
Output a message on tbpl summary box when autoclobbering
Review of attachment 8335907 [details] [diff] [review]:
-----------------------------------------------------------------
With a sheriff's blessing.
::: python/mozbuild/mozbuild/controller/clobber.py
@@ +180,5 @@
> required, performed, message = clobber.maybe_do_clobber(cwd, auto, fh)
>
> if not required or performed:
> + if performed and env.get('TINDERBOX_OUTPUT', False):
> + print('TinderboxPrint: auto clobber')
You don't need False since the default is None.
Attachment #8335907 -
Flags: review?(gps) → review+
| Assignee | ||
Comment 4•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•