Update b2gpopulate to use mozlog 1.4 with timestamps

RESOLVED FIXED

Status

Firefox OS
General
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: davehunt, Assigned: kyr0)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

4 years ago
Currently b2gpopulate defines its own formatter so it can output timestamps. Now this has been added to mozlog in version 1.4 we should update the dependency and use this instead.

See: https://github.com/mozilla/b2gpopulate/blob/335aad5b82e5f3dc75753d2219b79c731dc7f49c/b2gpopulate/b2gpopulate.py#L344
(Reporter)

Updated

4 years ago
Assignee: nobody → sebastiaan
(Assignee)

Comment 1

4 years ago
Created attachment 8336040 [details] [review]
Bug 541554 - b2g formatter replaced with mozlog

Is this what you meant Dave?
Attachment #8336040 - Flags: review?(dave.hunt)
(Assignee)

Comment 2

4 years ago
Created attachment 8336064 [details] [review]
Bug 941554 - b2g formatter replaced with mozlog
Attachment #8336040 - Attachment is obsolete: true
Attachment #8336040 - Flags: review?(dave.hunt)
Attachment #8336064 - Flags: review?(dave.hunt)
(Reporter)

Comment 3

4 years ago
Comment on attachment 8336064 [details] [review]
Bug 941554 - b2g formatter replaced with mozlog

As mentioned on the pull request, let's loosen the mozlog version dependency at the same time. With that change, r=me.
Attachment #8336064 - Flags: review?(dave.hunt) → review-
(Assignee)

Comment 4

4 years ago
Created attachment 8336986 [details] [review]
Bug 941554 - b2g formatter replaced with mozlog

>= processed.
Attachment #8336064 - Attachment is obsolete: true
Attachment #8336986 - Flags: review?(dave.hunt)
(Reporter)

Comment 5

4 years ago
Comment on attachment 8336986 [details] [review]
Bug 941554 - b2g formatter replaced with mozlog

Thanks! Landed in:
https://github.com/mozilla/b2gpopulate/commit/94355d1cc063f6104d44b4eeec9dcca0f67b0bee
Attachment #8336986 - Flags: review?(dave.hunt) → review+
(Reporter)

Updated

4 years ago
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.