941560 - Fix Line number color in "Dark theme".

Status: RESOLVED WORKSFORME

(DevTools :: Console, defect)

Description

[jorrete]

Attachment: dard_theme_devtools_console.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:25.0) Gecko/20100101 Firefox/25.0 (Beta/Release)
Build ID: 20131030131730

Steps to reproduce:

Activate "Dark theme" in Firefox Nightly.
Use console.log on a script a read the output on the console.


Actual results:

The line number color is blue and difficult to read in "Dark theme".


Expected results:

The line number color should have a better contrast with the "Dark theme"

Comment 1

[Mihai Sucan [:msucan]]

Jorette, do you have any customized colors for the anchors?

Comment 2

[jorrete]

(In reply to Mihai Sucan [:msucan] from comment #1)
> Jorette, do you have any customized colors for the anchors?

If you mean customized colors on style sheets of the page, no I don't.

Comment 3

[Brian Grinstead [:bgrins]]

Attachment: Screenshot 2013-11-21 13.03.21.png

This is what the links look like for me (on OSX).

Comment 4

[Brian Grinstead [:bgrins]]

Jorette, would you mind opening firefox with a clean profile just to double check that it is not something interacting with the colors?

Comment 5

[jorrete]

Attachment: devtools.png

I'am using Fedora 19 and Nightly (up to date).

Comment 6

[kr.kruk]

Attachment: devtools_screen.png

I can also confirm the problem. On Windows XP with ClearType on, Firefox 28, dark theme, it's almost impossible to see the file name or line number. I have to select the text, to read it.

Comment 7

[Brian Grinstead [:bgrins]]

Attachment: nightly-31-windows.jpg

This is a screenshot from Windows on the current nightly (31).

Comment 8

[Brian Grinstead [:bgrins]]

(In reply to kr.kruk from comment #6)
> Created attachment 8405277 [details]
> devtools_screen.png
> 
> I can also confirm the problem. On Windows XP with ClearType on, Firefox 28,
> dark theme, it's almost impossible to see the file name or line number. I
> have to select the text, to read it.

The problem doesn't appear to still exist in the latest Nightlies, so it seems that it was fixed somewhere between 28 and now.  My guess is that it is resolved in the current beta 29 (which is when the main theme changes landed).

Comment 9

[Brian Grinstead [:bgrins]]

(In reply to Brian Grinstead [:bgrins] from comment #8)
> (In reply to kr.kruk from comment #6)
> > Created attachment 8405277 [details]
> > devtools_screen.png
> > 
> > I can also confirm the problem. On Windows XP with ClearType on, Firefox 28,
> > dark theme, it's almost impossible to see the file name or line number. I
> > have to select the text, to read it.
> 
> The problem doesn't appear to still exist in the latest Nightlies, so it
> seems that it was fixed somewhere between 28 and now.  My guess is that it
> is resolved in the current beta 29 (which is when the main theme changes
> landed).

Actually, I can't reproduce on Windows 7 even with Firefox 28.  It would be great if you could download the nightly and check to see if it is still a problem: http://nightly.mozilla.org/.

Comment 10

[Rob Campbell [:rc] (:robcee)]

this appears to be a windows XP related bug based on the screenshots. We must have different hard-coded values for link colors on that platform (themes/windows/classic).

Comment 11

[Brian Grinstead [:bgrins]]

Attachment: nightly-32-ubuntu.png

Not seeing it on Ubuntu for nightly 32

Comment 12

[Panos Astithas (he/him) [:past] (please ni?)]

I'm pretty sure we had a bug to tweak the colors in the console output, which was fixed. Please reopen if you can reproduce this on Firefox 32.