941597 - [Regression] Error when using activity from contacts

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Borja Salguero [:borjasalguero]]

When tapping on 'message' icon in Contacts App:

E/GeckoConsole( 1259): [JavaScript Error: "TypeError: callback is not a function" {file: "app://sms.gaiamobile.org/js/thread_ui.js" line: 1101}]

Comment 1

[Borja Salguero [:borjasalguero]]

Attachment: Pull request

This is a regression, could you take a quick look? Thanks!

Comment 2

[Borja Salguero [:borjasalguero]]

This happens when creating a Contact, because onMozContactchange is adding the wrong callback object.

Comment 3

[Julien Wajsberg [:julienw]]

I'm removing the "regression" tag because I think there is no user-visible issue because of this.

That said, let's fix this bad log :)

Comment 4

[Julien Wajsberg [:julienw]]

Comment on attachment 8336016 [details] [review]
Pull request

There are other issues as well.

Please fix them and then it's r+.

Comment 5

[Julien Wajsberg [:julienw]]

Adding back the "regression" keyword as I think the other issues are actually causing a regression.

Comment 7

[Borja Salguero [:borjasalguero]]

Julien! I've fixed the issues you mentioned in the PR, could you take a look? Thanks!

Comment 8

[Julien Wajsberg [:julienw]]

Comment on attachment 8336016 [details] [review]
Pull request

The red travis is due to a test that has been backed out since then.

r=me you can land, but please file a follow-up bug for testing the contactchange event!

Comment 9

[Borja Salguero [:borjasalguero]]

Bug created! https://bugzilla.mozilla.org/show_bug.cgi?id=943178 :)

Comment 10

[Borja Salguero [:borjasalguero]]

https://github.com/mozilla-b2g/gaia/commit/9862c66e00264afb7cc773b3dd8286c65048fadb
https://github.com/borjasalguero/gaia/commit/53906820ec37e5ee8d16ddd7ad81ffc294407820
R+. Merged.

Comment 11

[Joe Cheng [:jcheng] (please needinfo)]

already in master. 1.3 , clear flag