941600 - [keyboard] notification how to change keyboard/input method is concatenated, should be completely localizable (missing whitespace)

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: screenshot of issue

Boot2Gecko 1.2.0.0-prerelease 20131120224415 on Keon

When opening the browser and entering the url bar, I got twice a notification how to change the keyboard (see screenshot) which lacks a whitespace after the colon and the name of the keyboard.

Actual: "Integrierte Tastatur:Deutsch"

Expected: "Integrierte Tastatur: Deutsch"

This is not a string in the localization files, so two string and a colon get concatenated.

Comment 1

[Axel Hecht [:Pike]]

This is 

this.fakenotiMessage.textContent = current.appName + ':' + current.name;

in https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/keyboard_manager.js#L541

The 1.2-able fix is to replace ':' with ': ', but the right fix for master is to create a localizable format string that takes the appName and the current.name as arguments.

Comment 2

[Francesco Lodolo [:flod]]

Attachment: Pull request on Github

Comment 3

[Francesco Lodolo [:flod]]

Attachment: Screenshot on patched Keon

Left English, right Italian.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Master: bff8d44240abc815fda5de90ae5d130b99b1b1df

Comment 5

[Francesco Lodolo [:flod]]

Verified on Keon, master git commit 3977de3c 2014-03-24