941622 - [Contacts] Update background and sub header colour

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Eric Pang [:epang] UX]

Attachment: 2013-11-21-13-53-15.png

The following updates are needed in Contact Settings

Background: f4f4f4
Sub header Background: e7e7e7

Comment 1

[Joshua Smith [:joshua-s]]

One little fix needed for this.

Comment 2

[Joshua Smith [:joshua-s]]

Attachment: PR on GitHub

Comment 3

[Joshua Smith [:joshua-s]]

Attachment: Contacts app after patch

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8339504 [details] [diff] [review]
PR on GitHub

Arnau, could you take a look to this pr?

Thanks!

Comment 5

[Eric Pang [:epang] UX]

(In reply to Joshua Smith [:joshua-s] from comment #3)
> Created attachment 8339513 [details]
> Contacts app after patch

Hey Joshua, thanks for working on this!
Some visual feedback, can you change the font weight of "Settings" to light?
Also, can you shift "order by last name" to have a 30px (3rem) left margin so it's aligned with the rest of the text on the screen?

If you can flag me for feedback that would be great - just so we can make sure the visual side is good.
Thanks!
Eric

Comment 6

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Comment on attachment 8339504 [details] [diff] [review]
PR on GitHub

Thanks Joshua, everything ok, you can merge this patch!

Comment 7

[Eric Pang [:epang] UX]

(In reply to Arnau March from comment #6)
> Comment on attachment 8339504 [details] [diff] [review]
> PR on GitHub
> 
> Thanks Joshua, everything ok, you can merge this patch!

Hi Joshua, don't worry about the alignment issue, I've opened a new bug for it (944544).  And regarding the font weight, it will be dealt with in the building blocks :). Thanks!

Comment 8

[Casey Yee]

Merged to master 1171e36

Comment 9

[Joshua Smith [:joshua-s]]

Great!