Closed
Bug 941628
Opened 11 years ago
Closed 11 years ago
[Settings] Update background and sub header colour
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: epang, Assigned: pivanov)
References
Details
(Whiteboard: ux-tracking, visual design, visual-tracking, jian)
Attachments
(2 files)
The following updates are needed in Settings Background: f4f4f4 Sub header Background: e7e7e7
All header confirmation button text that have 1.3's updated UI color scheme, like Settings, are white against a white background: ex. http://imgur.com/bMgMdF3,pJtX00D#0 & http://imgur.com/bMgMdF3,pJtX00D#1 Expected: Header confirmation button text stands out against the white background.
Reporter | ||
Comment 2•11 years ago
|
||
(In reply to gbennett from comment #1) > All header confirmation button text that have 1.3's updated UI color scheme, > like Settings, are white against a white background: ex. > http://imgur.com/bMgMdF3,pJtX00D#0 & http://imgur.com/bMgMdF3,pJtX00D#1 > > Expected: > Header confirmation button text stands out against the white background. Thanks for bring these up. I've noted these and will be opening separate bugs to address the header issues.
(In reply to Eric Pang [:epang] from comment #2) > (In reply to gbennett from comment #1) > > All header confirmation button text that have 1.3's updated UI color scheme, > > like Settings, are white against a white background: ex. > > http://imgur.com/bMgMdF3,pJtX00D#0 & http://imgur.com/bMgMdF3,pJtX00D#1 > > > > Expected: > > Header confirmation button text stands out against the white background. > > Thanks for bring these up. I've noted these and will be opening separate > bugs to address the header issues. The gear icon in the Usage app could also use some love. http://imgur.com/PihNf0c Would you like me to create a bug for it, or keep commenting on this bug for similar issues?
Reporter | ||
Comment 4•11 years ago
|
||
(In reply to gbennett from comment #3) > (In reply to Eric Pang [:epang] from comment #2) > > (In reply to gbennett from comment #1) > > > All header confirmation button text that have 1.3's updated UI color scheme, > > > like Settings, are white against a white background: ex. > > > http://imgur.com/bMgMdF3,pJtX00D#0 & http://imgur.com/bMgMdF3,pJtX00D#1 > > > > > > Expected: > > > Header confirmation button text stands out against the white background. > > > > Thanks for bring these up. I've noted these and will be opening separate > > bugs to address the header issues. > > The gear icon in the Usage app could also use some love. > http://imgur.com/PihNf0c Would you like me to create a bug for it, or keep > commenting on this bug for similar issues? I think we have it under control. thanks though! I've opened a bug that will update the colour of the settings icon in the usage apps. Thanks for pointed it out :)
Assignee | ||
Updated•11 years ago
|
Assignee: kyee → pivanov
Assignee | ||
Comment 6•11 years ago
|
||
Attachment #8339376 -
Flags: review?(epang)
Reporter | ||
Comment 7•11 years ago
|
||
Comment on attachment 8339376 [details] [review] patch for Gaia/master Looks good, thanks!
Attachment #8339376 -
Flags: review?(epang) → review+
Assignee | ||
Comment 8•11 years ago
|
||
Landed to master: https://github.com/mozilla-b2g/gaia/commit/2d6ba05411f25e6d37a54da9338956f2f1d7e852
You need to log in
before you can comment on or make changes to this bug.
Description
•