Closed
Bug 941726
Opened 10 years ago
Closed 10 years ago
Prevent DownloadLegacy from keeping a reference to the network request after the download is stopped
Categories
(Toolkit :: Downloads API, defect)
Toolkit
Downloads API
Tracking
()
RESOLVED
FIXED
mozilla30
People
(Reporter: Paolo, Assigned: Paolo)
References
Details
Attachments
(1 file)
|
4.79 KB,
patch
|
enndeakin
:
review+
|
Details | Diff | Splinter Review |
In bug 939510, a memory leak has been observed because the DownloadLegacy object kept a reference to the request object through a closure in the handler registered on deferCanceled.
Attachment #8336167 -
Flags: review?(enndeakin)
|
||
Updated•10 years ago
|
Attachment #8336167 -
Flags: review?(enndeakin) → review+
|
Assignee | |
Comment 1•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/f785bf2e2c51
|
||
Comment 2•10 years ago
|
||
had to backout this change in https://hg.mozilla.org/integration/fx-team/rev/b4284cae2bff because of test failures after this checkin like https://tbpl.mozilla.org/php/getParsedLog.php?id=31373611&tree=Fx-Team
|
|
Assignee | |
Comment 3•10 years ago
|
||
Pushed after green tryserver build (https://tbpl.mozilla.org/?tree=Try&rev=1fa836a41f8d): https://hg.mozilla.org/integration/fx-team/rev/8800134ab715
|
||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8800134ab715
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in
before you can comment on or make changes to this bug.
Description
•