Closed Bug 941736 Opened 10 years ago Closed 10 years ago

unify sources in chrome/src and most of extensions/

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla28

People

(Reporter: tbsaunde, Assigned: tbsaunde)

Details

(Whiteboard: [qa-])

Attachments

(1 file)

bug 941736 - unify sources in chrome/src and most of extensions/
7.34 KB, patch
ehsan.akhgari
: review+
Details | Diff | Splinter Review 
      No description provided.
Comment on attachment 8336176 [details] [diff] [review]
bug 941736 - unify sources in chrome/src and most of extensions/

Review of attachment 8336176 [details] [diff] [review]:
-----------------------------------------------------------------

::: extensions/auth/moz.build
@@ +11,5 @@
>      'nsAuthGSSAPI.cpp',
>      'nsAuthSASL.cpp',
> +]
> +
> +SOURCES += [

Please add a comment stating why this is not unified.

::: extensions/pref/autoconfig/src/nsAutoConfig.h
@@ +3,5 @@
>   * License, v. 2.0. If a copy of the MPL was not distributed with this
>   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>  
> +#ifndef nsAutoConfig_h_
> +#define nsAutoConfig_h_

Nit: please remove the trailing underscore here and below.
Attachment #8336176 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/mozilla-central/rev/557e799afd76
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.