941739 - Add current process ID to assertion failures

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Jason Orendorff [:jorendorff]]

Ideally thread ids too. Bug 931444 triggered this, because in the log there are two "Assertion failed" messages, and either one alone should have been fatal.

(I'd be happy if every line of the log had a pid and threadid on it. I hear concurrency is the future.)

Comment 1

[(no longer active)]

Please file another bug for the second paragraph :)

Comment 2

[Jason Orendorff [:jorendorff]]

Filed bug 941742.

Comment 3

[(no longer active)]

Attachment: Print the current process and thread information on XPCOM assertions and string leaks stats; r=froydnj

Comment 4

[Nathan Froyd [:froydnj]]

Comment on attachment 8336193 [details] [diff] [review]
Print the current process and thread information on XPCOM assertions and string leaks stats; r=froydnj

Review of attachment 8336193 [details] [diff] [review]:
-----------------------------------------------------------------

::: xpcom/string/src/nsSubstring.cpp
@@ +29,5 @@
> +#ifdef XP_WIN
> +#include <windows.h>
> +#include <process.h>
> +#define getpid() _getpid()
> +#define pthread_self() GetCurrentThreadId()

Ugh.  Can you file a followup bug for XPCOM on adding GetProcessId/GetThreadId (or whatever names won't conflict with windows headers) so we can not do this here?  (Other places do similar things, too, and those should be fixed as well.)

Comment 5

[(no longer active)]

Sure, filed bug 941801.

Comment 6

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bad7c90bb630

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/bad7c90bb630