941741 - Reset italic font-style for .box-links in Chinese (Traditional) in State of Mozilla 2012 pages

Status: VERIFIED FIXED

(www.mozilla.org :: Pages & Content, defect)

Description

[Peter Pin-Guang Chen [:petercpg] (MozTW.org)]

Chinese characters would look weird when font-style: italic is set, please reset to normal.

Flod, can you help on this?

Comment 1

[Francesco Lodolo [:flod]]

Assigning to myself to see if I can fix this.

Comment 2

[Francesco Lodolo [:flod]]

Attachment: Pointer to Github pull request: https://github.com/mozilla/bedrock/pull/1428

Pointer to Github pull-request

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/179e48edf292ab23ab07b87da41aedfdc03de515
Bug 941741 - Reset Italic style for Chinese (zh-CN, zh-TW)

https://github.com/mozilla/bedrock/commit/4963dd4d7158f3bc385564f3a655be3250b74a98
Merge pull request #1428 from flodolo/bug941741

Bug 941741 - State of Mozilla 2012 - Reset Italic style for Chinese (zh-CN, zh-TW)

Comment 4

[Francesco Lodolo [:flod]]

The change should be already available in production (it resets all text in Italic).

I see you're still missing a couple of strings from the main file, is that wanted?

Comment 5

[Peter Pin-Guang Chen [:petercpg] (MozTW.org)]

(In reply to Francesco Lodolo [:flod] from comment #4)
> The change should be already available in production (it resets all text in
> Italic).

Thanks, that looks good. (Alphabets like name and video titles are okay in italic, though)

> I see you're still missing a couple of strings from the main file, is that
> wanted?

Yes I just committed an update to the snippets. I called for l10n suggestions at local mailing list for some few strings such as the quote of Baker so they are left untranslated for now.


Marking as RESOLVED FIXED.