Closed Bug 941857 Opened 7 years ago Closed 7 years ago

Only build WMFPlatformDecoderModule when MOZ_WMF is defined

Categories

(Core :: Audio/Video, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: cpearce, Assigned: cpearce)

Details

(Whiteboard: [qa-])

Attachments

(1 file)

If you enable building the fmp4 demuxer on MacOSX, you get a compile error: 

 0:34.00 /Users/cdiehl/dev/repos/mozilla/mozilla-central-mp4/content/media/fmp4/wmf/MFTDecoder.h:10:10: fatal error: 'wmf.h' file not found

This is because we're trying to build the WMFPlatformDecoderModule backend, but that's silly since it can't possibly work on MacOSX.
Summary: Only build WMFPlatofmrDecoderModule when MOZ_WMF is defined → Only build WMFPlatofrmDecoderModule when MOZ_WMF is defined
Attached patch PatchSplinter Review
Don't build code when it won't work!
Attachment #8336350 - Flags: review?(kinetik)
Attachment #8336350 - Flags: review?(kinetik) → review+
Summary: Only build WMFPlatofrmDecoderModule when MOZ_WMF is defined → Only build WMFPlatformDecoderModule when MOZ_WMF is defined
https://hg.mozilla.org/mozilla-central/rev/bd8942ec737b
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.