94203 - Backup (All) button on Your Certificates tab active with no certs

Status: VERIFIED FIXED

(Core Graveyard :: Security: UI, defect, P3)

Description

[Jeffrey Baker]

Even if you have no certificates in the Your Certificates tab, the Backup button
will still do something when you press it.  On Mozilla 0.9.3/Linux, clicking the
button invokes the file selection dialog.

Comment 1

[Stephane Saux]

The backup button is properly disabled. It's the "Backup All" that is enabled
when you have no certs. Updating the summary to reflect that.
P3
->future.

We should check that whether there are any certs. The outliner has a useful
attribute:
  readonly attribute long rowCount;

Another problem is that the View, Backup, and Delete buttons are enabled even
when the selection is a container.  Use:
  boolean isContainer(in long index);
Note that the implementation needs to decide what to do when more than one
outliner items are selected.

Comment 2

[Jeffrey Baker]

No, the original description was correct.  The "Backup" button LOOKS disabled,
but if you click on it, you'll find that it ISN'T disabled.

Comment 3

[Stephane Saux]

You're right.
We actually have another bug that fixes this that is almost ready to check in. 
The fix is to change onclick to oncommand.
Marking dup of 88328.

*** This bug has been marked as a duplicate of 88328 ***

Comment 4

[Stephane Saux]

Change the target of bugs with state 'RESOLVED' and target 'Future' to target
'2.1' since they were fixed for the 2.1 release.

Comment 5

[Christina Fu]

I'm confused whether this bug has been claimed to be fixed or not.

Either way, I am still seeing "Backup all" pop up even though there's no user cert.
Observed on N6 23001091703.

Comment 6

[John Unruh]

Reopening. The original summary is still true. Tested on 9/19 WinNT branch.

Comment 7

[Rangan Sen]

Attachment: patch

Comment 8

[Rangan Sen]

David, please review ....

Comment 9

[David P. Drinan]

r=ddrinan.

Comment 10

[Joe Hewitt (gone)]

Comment on attachment 50165 [details] [diff] [review]
patch

sr=hewitt

Comment 11

[Rangan Sen]

Patch checked in..

Comment 12

[John Unruh]

Verified on 11/2 Linux trunk build.