Closed Bug 942033 Opened 6 years ago Closed 6 years ago

Build security/manager in unified mode

Categories

(Core :: Security: PSM, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

No description provided.
Attachment #8336590 - Flags: review?(brian)
Comment on attachment 8336590 [details] [diff] [review]
Build security/manager in unified mode; r=bsmith

Review of attachment 8336590 [details] [diff] [review]:
-----------------------------------------------------------------

::: security/manager/ssl/src/moz.build
@@ +70,5 @@
> +# nsCMS.cpp and nsNSSVersion.cpp cannot be built in unified mode becasue they
> +# #include smime.h which clashes with secmime.h.
> +# nsNSSCertificateDB.cpp needs to include nscert.h before everything else.
> +# nsNSSComponent.cpp cannot be build in unified mode because it wants to force
> +# NSPR logging.

This should no longer be necessary because bug 942035 was just landed in mozilla-inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/08e1c88ba2be.

Please update the patch with that in mind.
Attachment #8336590 - Flags: review?(brian) → review+
Depends on: 942035
https://hg.mozilla.org/mozilla-central/rev/798dc919d6bc
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.