942035 - Change the #include guard of smime.h

Status: RESOLVED FIXED

(NSS :: Libraries, defect)

Description

[(no longer active)]

The #include guard is currently _SECMIME_H_ which clashes with that of secmime.h.

Comment 1

[(no longer active)]

Attachment: Change the #include guard of smime.h to _SMIME_H_

Comment 2

[Ryan Sleevi]

Comment on attachment 8336591 [details] [diff] [review]
Change the #include guard of smime.h to _SMIME_H_

Review of attachment 8336591 [details] [diff] [review]:
-----------------------------------------------------------------

r+ rsleevi

Comment 3

[(no longer active)]

Thanks!  Can someone please help check in this patch for me?

Comment 4

[Ryan VanderMeulen [:RyanVM]]

(In reply to :Ehsan Akhgari (needinfo? me!) from comment #3)
> Thanks!  Can someone please help check in this patch for me?

Maybe kaie? :)

Comment 5

[Kai Engert (:KaiE:)]

https://hg.mozilla.org/projects/nss/rev/5cd75d66fd95

Comment 6

[(no longer active)]

Thanks, Kai!  What is the process of getting this patch ported to mozilla-central?

Comment 7

[Kai Engert (:KaiE:)]

(In reply to :Ehsan Akhgari (needinfo? me!) from comment #6)
> Thanks, Kai!  What is the process of getting this patch ported to
> mozilla-central?

A new beta tag of NSS needs to be produced and imported (using client.py).

Do you need it urgently, like, immediately?

If it can wait a few days - we'll have a new snapshot of NSS landed into mozilla-central during the next couple of days anyway.

Comment 8

[(no longer active)]

(In reply to comment #7)
> (In reply to :Ehsan Akhgari (needinfo? me!) from comment #6)
> > Thanks, Kai!  What is the process of getting this patch ported to
> > mozilla-central?
> 
> A new beta tag of NSS needs to be produced and imported (using client.py).
> 
> Do you need it urgently, like, immediately?

No, it's not urgent at all.

> If it can wait a few days - we'll have a new snapshot of NSS landed into
> mozilla-central during the next couple of days anyway.

That sounds perfect, thanks!  Is there a bug # that I can follow?

Comment 9

[Kai Engert (:KaiE:)]

Bug 898431 was used to update mozilla-inbound to a more recent snapshot of NSS (beta 4), which includes the fix for this bug.