Closed
Bug 942040
Opened 11 years ago
Closed 11 years ago
Remove a process from BackgroundProcessLRUPool in ParticularProcessPriorityManager only if it is indeed a background process
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(firefox26 unaffected, firefox27 fixed, firefox28 fixed, firefox-esr24 unaffected, b2g-v1.2 unaffected)
RESOLVED
FIXED
1.1 QE6
| Tracking | Status | |
|---|---|---|
| firefox26 | --- | unaffected |
| firefox27 | --- | fixed |
| firefox28 | --- | fixed |
| firefox-esr24 | --- | unaffected |
| b2g-v1.2 | --- | unaffected |
People
(Reporter: alan.yenlin.huang, Assigned: alan.yenlin.huang)
References
Details
(Whiteboard: [Fugu] [v1.2f-uplift-needed])
Attachments
(1 file)
|
1.07 KB,
patch
|
khuey
:
review+
bajaj
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
In bug 922919, I see a case that ProcessPriorityManager will construct BackgroundProcessLRUPool if we are destroying a non-background processes' ParticularProcessPriorityManager. This isn't right. Even though it won't affect 822325, but it affects 922919.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8336644 -
Flags: review?(khuey)
|
|
Assignee | |
Comment 2•11 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=9beca562d659
Attachment #8336644 -
Flags: review?(khuey) → review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/695c337d555f Please request Aurora approval on this patch as well.
status-b2g-v1.2:
--- → unaffected
status-firefox26:
--- → unaffected
status-firefox27:
--- → affected
status-firefox28:
--- → affected
status-firefox-esr24:
--- → unaffected
Keywords: checkin-needed
|
|
Assignee | |
Comment 4•11 years ago
|
||
Comment on attachment 8336644 [details] [diff] [review] Check PROCESS_PRIORITY_BACKGROUND in pppm shutdown() [Approval Request Comment] Bug caused by (feature/regressing bug #): bug 822325 User impact if declined: This impact mochitest. Some test may failed. Testing completed (on m-c, etc.): Yes, on Try https://tbpl.mozilla.org/?tree=Try&rev=9beca562d659 . Risk to taking this patch (and alternatives if risky): no String or IDL/UUID changes made by this patch: no
Attachment #8336644 -
Flags: approval-mozilla-aurora?
|
||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/695c337d555f
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Comment 6•11 years ago
|
||
Comment on attachment 8336644 [details] [diff] [review] Check PROCESS_PRIORITY_BACKGROUND in pppm shutdown() low risk patch avoiding mochitest failures.
Attachment #8336644 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
|
||
Comment 7•11 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/5217272bd8fd
Target Milestone: --- → 1.1 QE6
|
||
Updated•11 years ago
|
Whiteboard: [Fugu] [v1.2f-uplift-needed]
You need to log in
before you can comment on or make changes to this bug.
Description
•