Closed Bug 942102 Opened 6 years ago Closed 6 years ago

Intermittent 2 nsGlobalWindows leaked until shutdown mostly during OSX 10.8 opt debugger BC tests

Categories

(DevTools :: Debugger, defect)

All
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: mccr8, Assigned: shu)

References

Details

(Keywords: intermittent-failure, memory-leak, meta)

There are a ridiculous number of these, so they deserve their own meta bug.  These were made worse by bug 933882 which eliminated GCs when switching to debugging mode, but they were pre-existing.  Weirdly, this is mostly 10.8 opt only.  I got this list of bugs by searching for |debugger "leaked until shutdown"| in bugzilla.  It seems like there must be some underlying problem in the debugger that just ends up manifesting across many tests.

shu has started investigating this in bug 941787.

A slight variation in the pattern is bug 934791, which was on 10.6, though it only happened once.
There are also some web console variants of this, like bug 942048.
There's an increase of memleaks in webconsole tests as well, when they open the debugger. See bug 937912 and bug 941954. Should we add these bugs to the dependency list?
Depends on: 942048
Depends on: 942047
(In reply to Mihai Sucan [:msucan] from comment #2)
> There's an increase of memleaks in webconsole tests as well, when they open
> the debugger. See bug 937912 and bug 941954. Should we add these bugs to the
> dependency list?

Sure, if you'd like.
Depends on: 942039
Summary: Intermittent 2 nsGlobalWindows leaked until shutdown during debugger BC tests on OSX 10.8 opt → Intermittent 2 nsGlobalWindows leaked until shutdown mostly during OSX 10.8 opt debugger BC tests
Depends on: 942110
On TBPL I mostly see that the URLs of the windows that leak are of the tabs that the tests make themselves. Running these tests locally on repeat until failure, however, sometimes get me different leaks:

 3:24.43 TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_search-global-04.js | leaked until shutdown [nsGlobalWindow #1432 about:blank]
 3:24.43 TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_search-global-04.js | leaked until shutdown [nsGlobalWindow #1433 about:blank]
 3:24.43 TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_search-global-04.js | leaked until shutdown [nsGlobalWindow #1435 data:text/html;charset=utf8,<!DOCTYPE%20html><html%20dir='ltr'>%20%20<head>%20%20%20%20<style>%20%20%20%20%20%20html,%20body%20{%20height:%20100%;%20}%20%20%20%20%20%20body%20{%20margin:%200;%20overflow:%20hidden;%20}%20%20%20%20%20%20.CodeMirror%20{%20width:%20100%;%20height:%20100%%20!important;%20line-height:%20normal!important}%20%20%20%20</style>%20%20%20%20<link%20rel='stylesheet'%20href='chrome://browser/skin/devtools/common.css'>%20%20%20%20<link%20rel='stylesheet'%20href='chrome://browser/content/devtools/codemirror/codemirror.css'>%20%20%20%20<link%20rel='stylesheet'%20href='chrome://browser/content/devtools/codemirror/dialog.css'>%20%20%20%20<link%20rel='stylesheet'%20href='chrome://browser/content/devtools/codemirror/mozilla.css'>%20%20</head>%20%20<body%20class='theme-body%20devtools-monospace'></body></html>]
 3:24.43 TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_search-global-04.js | leaked until shutdown [nsGlobalWindow #1434 data:text/html;charset=utf8,<!DOCTYPE%20html><html%20dir='ltr'>%20%20<head>%20%20%20%20<style>%20%20%20%20%20%20html,%20body%20{%20height:%20100%;%20}%20%20%20%20%20%20body%20{%20margin:%200;%20overflow:%20hidden;%20}%20%20%20%20%20%20.CodeMirror%20{%20width:%20100%;%20height:%20100%%20!important;%20line-height:%20normal!important}%20%20%20%20</style>%20%20%20%20<link%20rel='stylesheet'%20href='chrome://browser/skin/devtools/common.css'>%20%20%20%20<link%20rel='stylesheet'%20href='chrome://browser/content/devtools/codemirror/codemirror.css'>%20%20%20%20<link%20rel='stylesheet'%20href='chrome://browser/content/devtools/codemirror/dialog.css'>%20%20%20%20<link%20rel='stylesheet'%20href='chrome://browser/content/devtools/codemirror/mozilla.css'>%20%20</head>%20%20<body%20class='theme-body%20devtools-monospace'></body></html>]
Depends on: 937912, 941954
This is a meta bug, not an individual failure.
(In reply to Andrew McCreight [:mccr8] from comment #5)
> This is a meta bug, not an individual failure.

Yeah I realise, we still typically use the keyword for them. (This shouldn't show up for anything failures, so won't get starred).
Ah, sorry!  Good to know.
Depends on: 942526
It looks like most of these should be fixed by bug 941787.
So we should go through the blocking bugs here in a few weeks and close any that haven't happened again.
Whiteboard: [MemShrink]
Depends on: 943787
Depends on: 943788
Depends on: 943799
Depends on: 944297
Depends on: 944317
I split off the non-debugger leaks into bug 944433, which seem mostly related to extension installation.
Fixed by bug 941787.
Assignee: nobody → shu
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WORKSFORME
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.