Closed
Bug 942112
Opened 11 years ago
Closed 11 years ago
Black bottom line missing from the toolbars
Categories
(DevTools :: Inspector, defect)
DevTools
Inspector
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 28
People
(Reporter: vporof, Assigned: bgrins)
References
Details
(Whiteboard: [good first verify])
Attachments
(2 files, 1 obsolete file)
|
44.88 KB,
image/png
|
Details | |
|
3.79 KB,
patch
|
paul
:
review+
|
Details | Diff | Splinter Review |
Screen Shot 2013-11-22 at 14.56.16.png
This is mostly obvious with the inspector. All tools are affected. See screenshot.
|
Assignee | |
Comment 2•11 years ago
|
||
Victor, does this fix the problem?
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Attachment #8336777 -
Flags: feedback?(vporof)
Flags: needinfo?(bgrinstead)
|
Reporter | |
Comment 3•11 years ago
|
||
Yes.
|
|
Reporter | |
Updated•11 years ago
|
Attachment #8336777 -
Flags: feedback?(vporof) → feedback+
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8336777 -
Flags: review?(paul)
|
||
Updated•11 years ago
|
Attachment #8336777 -
Flags: review?(paul) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
Paul, had a conflict when rebasing, and just want to make sure we are on the same page here. There was a background color added to the .devtools-toolbar (see this comment: https://bugzilla.mozilla.org/show_bug.cgi?id=929127#c32). Based on this comment, I'm thinking the background-image and box-shadow were intended to be removed, but since I had moved them to a different file during that bug they weren't. Either way, because of this background-color the background image in light and dark theme was not showing anymore - which seems to match the screens: https://people.mozilla.org/~shorlander/mockups/devTools/ux-refresh-2013/DarkTheme-Inspector-Active@2x.png, so I went ahead and dropped it from the theme files.
Attachment #8336804 -
Flags: review?(paul)
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8336777 -
Attachment is obsolete: true
|
|
||
Updated•11 years ago
|
Attachment #8336804 -
Flags: review?(paul) → review+
|
|
Assignee | |
Comment 5•11 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/3d17d686542d
Whiteboard: [fixed-in-fx-team]
|
||
Comment 6•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/3d17d686542d
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 28
|
||
Updated•10 years ago
|
Whiteboard: [good first verify]
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•