Closed Bug 942112 Opened 6 years ago Closed 6 years ago

Black bottom line missing from the toolbars

Categories

(DevTools :: Inspector, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 28

People

(Reporter: vporof, Assigned: bgrins)

References

(Blocks 1 open bug)

Details

(Whiteboard: [good first verify])

Attachments

(2 files, 1 obsolete file)

This is mostly obvious with the inspector. All tools are affected. See screenshot.
See bug 916766 comment 42.
Flags: needinfo?(bgrinstead)
Attached patch border-bottom.patch (obsolete) — Splinter Review
Victor, does this fix the problem?
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Attachment #8336777 - Flags: feedback?(vporof)
Flags: needinfo?(bgrinstead)
Yes.
Attachment #8336777 - Flags: feedback?(vporof) → feedback+
Attachment #8336777 - Flags: review?(paul)
Blocks: 916766
Attachment #8336777 - Flags: review?(paul) → review+
Paul, had a conflict when rebasing, and just want to make sure we are on the same page here.  There was a background color added to the .devtools-toolbar (see this comment: https://bugzilla.mozilla.org/show_bug.cgi?id=929127#c32).  Based on this comment, I'm thinking the background-image and box-shadow were intended to be removed, but since I had moved them to a different file during that bug they weren't.  Either way, because of this background-color the background image in light and dark theme was not showing anymore - which seems to match the screens: https://people.mozilla.org/~shorlander/mockups/devTools/ux-refresh-2013/DarkTheme-Inspector-Active@2x.png, so I went ahead and dropped it from the theme files.
Attachment #8336804 - Flags: review?(paul)
Attachment #8336777 - Attachment is obsolete: true
Attachment #8336804 - Flags: review?(paul) → review+
https://hg.mozilla.org/mozilla-central/rev/3d17d686542d
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 28
Whiteboard: [good first verify]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.