Closed Bug 942114 Opened 11 years ago Closed 11 years ago

Intermittent TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/markupview/test/browser_inspector_markup_765105_tooltip.js | Tooltip image has the right content

Categories

(DevTools :: Inspector, defect)

x86
Linux
defect
Not set
normal

Tracking

(firefox26 unaffected, firefox27 unaffected, firefox28 fixed, firefox-esr24 unaffected)

RESOLVED FIXED
Firefox 28
Tracking Status
firefox26 --- unaffected
firefox27 --- unaffected
firefox28 --- fixed
firefox-esr24 --- unaffected

People

(Reporter: cbook, Assigned: pbro)

References

()

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Ubuntu VM 12.04 x64 mozilla-central pgo test mochitest-browser-chrome on 2013-11-21 19:35:20 PST for push 7225e584d6c7

slave: tst-linux64-ec2-146

https://tbpl.mozilla.org/php/getParsedLog.php?id=30933728&tree=Mozilla-Central

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/markupview/test/browser_inspector_markup_765105_tooltip.js | Tooltip image has the right content -
The failure happens when testing for a remote image tooltip. The test tries to wait for the image to be loaded from the test server, but that seems to fail as the image data is an empty string.
I'm working (in another bug) on making sure tooltips are only shown when the content is available, so that should solve this issue.
Assignee: nobody → pbrosset
On second thought, waiting for the image to be loaded isn't an ideal solution especially when images are big and take time to download from the actor, we may instead want to show the tooltip as quickly as possible and have a "please wait" kind of message.

So to stop these test failures I suggest removing the image-data comparison since it's error prone and isn't bringing valuable test assertions.
Comment on attachment 8337010 [details] [diff] [review]
bug942114-intermittent-markup-image-tooltip.patch

Review of attachment 8337010 [details] [diff] [review]:
-----------------------------------------------------------------

Oranges seem to be unrelated, r+
Keywords: checkin-needed
Attachment #8337010 - Flags: review?(mratcliffe) → review+
https://hg.mozilla.org/integration/fx-team/rev/0730f476356f
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/0730f476356f
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 28
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: