942205 - Initialize ParallelArray class in GlobalObject::initStandardClasses.

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Till Schneidereit [:till]]

Enable eager initialization of ParallelArray

Comment 1

[Till Schneidereit [:till]]

Attachment: Part 3: Initialize ParallelArray class in GlobalObject::initStandardClasses

Comment 2

[Till Schneidereit [:till]]

Comment on attachment 8336858 [details] [diff] [review]
Part 3: Initialize ParallelArray class in GlobalObject::initStandardClasses

Clearly, I don't know how to use bzexport. This depends on two other patches, coming right up.

Comment 3

[Till Schneidereit [:till]]

Attachment: Part 2: Use JSPropertySpec[] to install ParallelArray#length getter.

Comment 4

[Till Schneidereit [:till]]

Attachment: Part 1: Skip self-hosted properties while initializing the self-hosting global

Comment 5

[Till Schneidereit [:till]]

Comment on attachment 8336858 [details] [diff] [review]
Part 3: Initialize ParallelArray class in GlobalObject::initStandardClasses

Sorry for the noise :(

Comment 6

[Niko Matsakis [:nmatsakis]]

What is the motivation for this change?

Comment 7

[Niko Matsakis [:nmatsakis]]

(In particular, ParallelArray is basically deprecated)

Comment 8

[Niko Matsakis [:nmatsakis]]

Comment on attachment 8336858 [details] [diff] [review]
Part 3: Initialize ParallelArray class in GlobalObject::initStandardClasses

Review of attachment 8336858 [details] [diff] [review]:
-----------------------------------------------------------------

r+ if the code is made conditional

::: js/src/vm/GlobalObject.cpp
@@ +483,5 @@
>             GlobalObject::initSetIteratorProto(cx, global) &&
>  #if EXPOSE_INTL_API
>             js_InitIntlClass(cx, global) &&
>  #endif
> +           js_InitParallelArrayClass(cx, global) &&

We want this to be #if ENABLE_PARALLEL_ARRAY or whatever that is called.

Comment 9

[Till Schneidereit [:till]]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/b4b90d586dfc
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/630a4c1f91b6
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/324d93c55cc5

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b4b90d586dfc
https://hg.mozilla.org/mozilla-central/rev/630a4c1f91b6
https://hg.mozilla.org/mozilla-central/rev/324d93c55cc5