If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Initialize ParallelArray class in GlobalObject::initStandardClasses.

RESOLVED FIXED in mozilla28

Status

()

Core
JavaScript Engine
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: till, Assigned: till)

Tracking

unspecified
mozilla28
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(3 attachments)

(Assignee)

Description

4 years ago
Enable eager initialization of ParallelArray
(Assignee)

Comment 1

4 years ago
Created attachment 8336858 [details] [diff] [review]
Part 3: Initialize ParallelArray class in GlobalObject::initStandardClasses
Attachment #8336858 - Flags: review?(nmatsakis)
(Assignee)

Comment 2

4 years ago
Comment on attachment 8336858 [details] [diff] [review]
Part 3: Initialize ParallelArray class in GlobalObject::initStandardClasses

Clearly, I don't know how to use bzexport. This depends on two other patches, coming right up.
Attachment #8336858 - Attachment description: Initialize ParallelArray class in GlobalObject::initStandardClasses. → Initialize ParallelArray class in GlobalObject::initStandardClasses. (3/3)
(Assignee)

Comment 3

4 years ago
Created attachment 8336860 [details] [diff] [review]
Part 2: Use JSPropertySpec[] to install ParallelArray#length getter.
Attachment #8336860 - Flags: review?(nmatsakis)
(Assignee)

Comment 4

4 years ago
Created attachment 8336861 [details] [diff] [review]
Part 1: Skip self-hosted properties while initializing the self-hosting global
Attachment #8336861 - Flags: review?(nmatsakis)
(Assignee)

Comment 5

4 years ago
Comment on attachment 8336858 [details] [diff] [review]
Part 3: Initialize ParallelArray class in GlobalObject::initStandardClasses

Sorry for the noise :(
Attachment #8336858 - Attachment description: Initialize ParallelArray class in GlobalObject::initStandardClasses. (3/3) → Part 3: Initialize ParallelArray class in GlobalObject::initStandardClasses
What is the motivation for this change?
(In particular, ParallelArray is basically deprecated)
Attachment #8336861 - Flags: review?(nmatsakis) → review+
Attachment #8336860 - Flags: review?(nmatsakis) → review+
Comment on attachment 8336858 [details] [diff] [review]
Part 3: Initialize ParallelArray class in GlobalObject::initStandardClasses

Review of attachment 8336858 [details] [diff] [review]:
-----------------------------------------------------------------

r+ if the code is made conditional

::: js/src/vm/GlobalObject.cpp
@@ +483,5 @@
>             GlobalObject::initSetIteratorProto(cx, global) &&
>  #if EXPOSE_INTL_API
>             js_InitIntlClass(cx, global) &&
>  #endif
> +           js_InitParallelArrayClass(cx, global) &&

We want this to be #if ENABLE_PARALLEL_ARRAY or whatever that is called.
Attachment #8336858 - Flags: review?(nmatsakis) → review+
(Assignee)

Comment 9

4 years ago
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/b4b90d586dfc
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/630a4c1f91b6
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/324d93c55cc5
https://hg.mozilla.org/mozilla-central/rev/b4b90d586dfc
https://hg.mozilla.org/mozilla-central/rev/630a4c1f91b6
https://hg.mozilla.org/mozilla-central/rev/324d93c55cc5
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28

Updated

4 years ago
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.