Closed Bug 942205 Opened 7 years ago Closed 7 years ago

Initialize ParallelArray class in GlobalObject::initStandardClasses.

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: till, Assigned: till)

Details

(Whiteboard: [qa-])

Attachments

(3 files)

Enable eager initialization of ParallelArray
Comment on attachment 8336858 [details] [diff] [review]
Part 3: Initialize ParallelArray class in GlobalObject::initStandardClasses

Clearly, I don't know how to use bzexport. This depends on two other patches, coming right up.
Attachment #8336858 - Attachment description: Initialize ParallelArray class in GlobalObject::initStandardClasses. → Initialize ParallelArray class in GlobalObject::initStandardClasses. (3/3)
Comment on attachment 8336858 [details] [diff] [review]
Part 3: Initialize ParallelArray class in GlobalObject::initStandardClasses

Sorry for the noise :(
Attachment #8336858 - Attachment description: Initialize ParallelArray class in GlobalObject::initStandardClasses. (3/3) → Part 3: Initialize ParallelArray class in GlobalObject::initStandardClasses
What is the motivation for this change?
(In particular, ParallelArray is basically deprecated)
Attachment #8336861 - Flags: review?(nmatsakis) → review+
Attachment #8336860 - Flags: review?(nmatsakis) → review+
Comment on attachment 8336858 [details] [diff] [review]
Part 3: Initialize ParallelArray class in GlobalObject::initStandardClasses

Review of attachment 8336858 [details] [diff] [review]:
-----------------------------------------------------------------

r+ if the code is made conditional

::: js/src/vm/GlobalObject.cpp
@@ +483,5 @@
>             GlobalObject::initSetIteratorProto(cx, global) &&
>  #if EXPOSE_INTL_API
>             js_InitIntlClass(cx, global) &&
>  #endif
> +           js_InitParallelArrayClass(cx, global) &&

We want this to be #if ENABLE_PARALLEL_ARRAY or whatever that is called.
Attachment #8336858 - Flags: review?(nmatsakis) → review+
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.