942219 - Wrong homebrew url in bootstrap-mac.sh

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Pete Moore [:pmoore][:pete]]

Attachment: bootstrap_homebrew_url_mac_fix_b2g.patch

The bootstrap script for mac points to:
        https://raw.github.com/mxcl/homebrew/go
for auto-downloading homebrew.

This script resides here:
        https://raw.github.com/mxcl/homebrew/go/install

This patch fixes this.

Comment 1

[Chris AtLee [:catlee]]

Comment on attachment 8336876 [details] [diff] [review]
bootstrap_homebrew_url_mac_fix_b2g.patch

I don't think I'm the right person to review this.

Comment 2

[Pete Moore [:pmoore][:pete]]

Comment on attachment 8336876 [details] [diff] [review]
bootstrap_homebrew_url_mac_fix_b2g.patch

Hey Ben,

Is this something you can review for me?

Thanks,
Pete

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8336876 [details] [diff] [review]
bootstrap_homebrew_url_mac_fix_b2g.patch

It looks good to me, but I'm not a peer for b2g.  Vivien is a b2g peer and recommended mwu on irc.

Comment 4

[Michael Wu [:mwu]]

Comment on attachment 8336876 [details] [diff] [review]
bootstrap_homebrew_url_mac_fix_b2g.patch

Marshall or Sheppy know this script the best.

Comment 5

[Marshall Culpepper [:marshall_law]]

Comment on attachment 8336876 [details] [diff] [review]
bootstrap_homebrew_url_mac_fix_b2g.patch

Review of attachment 8336876 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me :)

Comment 6

[Marshall Culpepper [:marshall_law]]

https://github.com/mozilla-b2g/B2G/commit/05b336020a7df015dcea453d8c52dc77f458a7f1