942239 - [B2G][Dialer][Log]Attaching a number from call logs to a contact downloaded from facebook displays inappropriately.

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Ross Kuhlman ([e-mail])]

Attachment: logcat.txt

The user has copied a contact from facebook to their phone. The facebook contact has a phone number already associated with it. (This number must be copied directly from facebook - not added to the contact after it is copied to the phone.) When the user adds a phone number from their call logs to this contact, the edit contact page displays inappropriately.

Prerequisites: A facebook contact with an associated phone number has been copied to your phone contacts. Have a call to/from an unknown number in your call logs.

Repro Steps:
1) Updated Buri to Build ID: 20131122004001
2) Launch Dialer app.
3) Navigate to Call Logs tab.
4) Tap on unknown number in log.
5) Select 'Add to existing contact'.
6) Observe only one phone number is displayed in 'Edit Contact' page.
7) Press the 'Update' button to add the number to the contact.
8) Observe contact details in Contacts app.

Actual:
Edit contact page only displays the new phone number, and not the original number from facebook. However, both numbers are saved to the contact.

Expected:
Edit contact page displays original phone number AND new phone number. Both numbers are properly saved to the contact.

Environmental Variables
Device: Buri v1.2 COM RIL
Build ID: 20131122004001
Gecko: http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/866496ed1f26
Gaia: 7b24f1d1f167fc40b1e887f4ff3746d383af3c2f
Platform Version: 26.0
RIL Version: 01.02.00.019.102 
Firmware Version: V1.2_20131115

Notes:
Repro frequency: 100%
Link to failed test case:
See attached screenshots and logcat.

Optional extra notes:
Phone numbers are saved appropriately. Only the 'Edit Contact' page displays inappropriately.

Comment 1

[Ross Kuhlman ([e-mail])]

Attachment: Contact Info Before

Comment 2

[Ross Kuhlman ([e-mail])]

Attachment: Adding Second Number

Comment 3

[Ross Kuhlman ([e-mail])]

Attachment: Contact Info After

Comment 4

[Ross Kuhlman ([e-mail])]

Issue also occurs in 1.1

Comment 5

[Ross Kuhlman ([e-mail])]

Forgot to link to failed test case.
https://moztrap.mozilla.org/manage/case/6964/

Comment 6

[Anthony Ricaud (:rik)]

This looks like a Contacts app issue rather than Dialer.

Comment 7

[Jose Manuel Cantera]

Is this really a bug? As the FB information cannot be edited by the user it will not provide anything useful to the user. 

Asking Ayman ...

Comment 8

[ayman maat :maat]

(In reply to Anthony Ricaud (:rik) from comment #6)
> This looks like a Contacts app issue rather than Dialer.

This is a contacts app issue I believe.


(In reply to Jose M. Cantera from comment #7)
> Is this really a bug? As the FB information cannot be edited by the user it
> will not provide anything useful to the user. 
> 
> Asking Ayman ...

This behaviour is something i raised ages ago with Dan when he did the UX for FB integration because it is one of the aspects of FB integration I disagree with. It is quite disorientating for users to see all information associated to a contact on the contact detail card, but see only some of it (the editable items) when they enter edit mode for that contact. 

I am of the opinion that when the user enters edit mode for a given contact we should show *all* information that is associated to the contact in question - but obviously information that is not editable (like FB information) should be presented but not editable and clearly indicated as being associated to FB. 

Likewise in the contact detail view information that belongs to FB should be marked as so so that the user can make a behavioural connection between information presented in the contact detail card and information that is presented and yet not editable when the contact details card is in edit mode  

From a UX perspective this is the path we should follow. 
We would require some IxD and Visual Design work in order to achieve this.

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

We implement this correctly on the last form redesign