Closed
Bug 942251
Opened 11 years ago
Closed 10 years ago
CompileOptions::setElementProperty and elementProperty should be named "...AttributeName"
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: jimb, Assigned: jimb)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
It's the attributes of a DOM element that matter; not all of them are reflected as properties on the JS object. So this was a misnomer. The corresponding ScriptSourceObject and Debugger bits should be renamed accordingly, and docs fixed.
|
Assignee | |
Updated•11 years ago
|
Summary: CompileOptions::setElementProperty and elementProperty should be named "...Attribute" → CompileOptions::setElementProperty and elementProperty should be named "...AttributeName"
|
|
Assignee | |
Comment 1•11 years ago
|
||
bz and bholley have been working on actually adding support for this to the browser, and both said it should be 'attributeName', not 'property'. Let's get this in before their patch.
|
|
Assignee | |
Comment 2•11 years ago
|
||
They're working in bug 941876, for reference.
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8337949 [details] [diff] [review] Rename Debugger.Script.prototype.elementProperty to elementAttributeName, and all related. Review of attachment 8337949 [details] [diff] [review]: ----------------------------------------------------------------- Sorry for the delay; took the last 2 days off.
Attachment #8337949 -
Flags: review?(sphink) → review+
|
||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8bcd545cf484
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
|
||
Updated•10 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•