942286 - tabs module tabs.on('activate') does not fire when Firefox Options->Tabs->Open New Windows in New Tab instead is unchecked (edit) and new window is opened or new tabs are created that way

Status: RESOLVED INCOMPLETE

(Add-on SDK Graveyard :: General, defect, P2)

Description

[felix.shnir]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/32.0.1700.19 Safari/537.36

Steps to reproduce:

main.js contains this code:
		SDK.tabs.on('activate', function (tab) {
			console.log('hai');
		});

If opening new window or switching to a tab, hai is printed in console.

Went to change this option: Firefox Options->Tabs->Open New Windows in New Tab instead -- its unchecked now.  Went on ghostery.com and clicked on support (new window will be opened now). First page looks fine, now create a few tabs there: CTRL + T -- as you can see hai is no longer printed for the window that "support click" open window when you switch the tabs.



Actual results:

hai is not printed because event never gets fired for the windows that are opened through that option.


Expected results:

event should have fired

Comment 1

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Someone should look into it (it's not quite what I though it was during triage) & we should set a priority
on next triage.

Comment 2

[Ben McCann]

This appears to be broken still on Firefox 40

A couple updates for testing. The preference is now located under "General > Open new windows in a new tab instead" and on the ghostery.com you can click the "Support Forums" link to reproduce

Comment 3

[Matteo Ferretti [:zer0] [:matteo]]

In accordance with Jacobo Aragunde Pérez this bug should be fixed by bug 993015; but it would need tests.

Comment 4

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1399562