942294 - unable swipe from e.me to apps page if swipe starts at edge of screen

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

On recent v1.2, if you attempt to swipe from the initial homescreen page with the e.me search box to the first screen of apps, sometimes you will not be able to.  Specifically, if you start your swipe at the edge of the screen then the swipe seems to stop "pulling" the page after a few pixels.

Here is a video showing the problem:

  https://www.dropbox.com/s/s78owgc91nwr0d6/20131122_homescreen_swipe.mp4

Work around is to start your swipe from an interior part of the page.  I seem to hit this naturally, though, when trying to swipe one-handed using my thumb.

Nom'ing for koi? to get this looked at in triage and because its bad UX.  Since the work-around is so easy, though, I understand if this gets koi-.

Comment 1

[Jason Smith [:jsmith]]

This is likely a regression.

Comment 2

[Matthew Vaughan]

This issue started reproducing on the 11/08/13 1.2 build.

- Works -
Environmental Variables:
Device: Buri v1.2 COM RIL
BuildID: 20131107004003
Gaia: 590eb598aacf1e2136b2b6aca5c3124557a365ca
Gecko: 26f1e160e696
Version: 26.0
Firmware Version: 20131115
RIL Version: 01.01.00.019.281

- Broken -
Environmental Variables:
Device: Buri v1.2 COM RIL
BuildID: 20131108004004
Gaia: 4cf40fb30c7b8380ea83ed0d4efe043b8b81737f
Gecko: a886c641a306
Version: 26.0
Firmware Version: 20131115
RIL Version: 01.02.00.019.102

Comment 4

[Jason Smith [:jsmith]]

Cristian - Can you take this?

Comment 5

[Cristian Rodriguez (:crdlc)]

Attachment: Patch v1

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 8339419 [details]
Patch v1

Christian could you explain what's going on, this patch seems like a workaround around some event handling weirdness.

Comment 7

[Cristian Rodriguez (:crdlc)]

Well, this is not a workaround, I mean, theoretically for panning we have to listen for touchstart in the container and for touchmove and touchend in window as usual. The current implementation was done when someone added a library to support mouse events without implementing them correctly in the homescreen. When this library was removed and the mouse/touch events were supported by the homescreen, that code wasn't changed. If you start the movement on the edge and the next page enter in the viewport, maybe the thumb finger could touch the next page and we are listening for the movement only in the current page. This is the implementation that you and me did [1] then listening in the container for move events doesn't make sense according to our implementation as you can see in this link of github.

[1] https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/js/grid.js#L408

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 8339419 [details]
Patch v1

Thanks for the explanation. Then this is a regression.

Comment 9

[Cristian Rodriguez (:crdlc)]

Merged in master:

https://github.com/mozilla-b2g/gaia/commit/833afc850d7a62a15ff1b178db806210f2ac839f

Thanks Vivien

Comment 10

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 833afc850d7a62a15ff1b178db806210f2ac839f to:
v1.2: 6fe8014dc2c8442b8f7fe8640b9d561595bcd066

Comment 11

[Roland Kunkel [:RolandK]]

Unable to reproduce on either the 1.3 or 1.2 builds. When selecting the edge of the screen, I am able to swipe to the next page as expected. Verifying as fixed. 

1.2 Environmental Variables:
Device: Buri v1.2 COM RIL
BuildID: 20131204004003
Gecko: http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/244e98241b2c
Gaia: c8f14ad3950d59ba13d7639eff02d080060bb3ce
Version: 26.0
RIL Version: 01.02.00.019.102
Firmware Version: V1.2_20131115

1.3 Environmental Variables
Device: Buri v1.3 Mozilla RIL
Build ID: 20131203040236
Gecko: http://hg.mozilla.org/mozilla-central/rev/8648aa476eef
Gaia: 31808a29cfcffa584b6a88b4f1e515387f485a1b
Platform Version: 28.0a1
Firmware Version: v1.2_20131115