942304 - Avoid rooting hazard in ArrayBufferObject::neuterViews

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Steve Fink [:sfink] [:s:]]

Staticify!

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Avoid rooting hazard in ArrayBufferObject::neuterViews

Comment 2

[Terrence Cole [:terrence]]

Comment on attachment 8337015 [details] [diff] [review]
Avoid rooting hazard in ArrayBufferObject::neuterViews

Review of attachment 8337015 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the one change.

::: js/src/vm/TypedArrayObject.h
@@ +197,5 @@
>  
>      /*
>       * Neuter all views of an ArrayBuffer.
>       */
> +    static bool neuterViews(Handle<ArrayBufferObject*> buffer, JSContext *cx);

|cx| still comes first.

Comment 3

[Steve Fink [:sfink] [:s:]]

Attachment: Avoid rooting hazard in ArrayBufferObject::neuterViews

Fixed the ordering

Comment 4

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8337022 [details] [diff] [review]
Avoid rooting hazard in ArrayBufferObject::neuterViews

terrence's r+ (uploaded new patch so I can set checkin-needed)

Comment 5

[Steve Fink [:sfink] [:s:]]

Attachment: Drop expectation to 10 hazards

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/46d26b2bc1f0

I'm assuming this is [leave open] until the other patch lands as well.

Comment 7

[Terrence Cole [:terrence]]

Comment on attachment 8337088 [details] [diff] [review]
Drop expectation to 10 hazards

Review of attachment 8337088 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/46d26b2bc1f0

Comment 9

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8337088 [details] [diff] [review]
Drop expectation to 10 hazards

(In reply to Ryan VanderMeulen [:RyanVM UTC-5][Back 2-Dec] from comment #6)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/46d26b2bc1f0
> 
> I'm assuming this is [leave open] until the other patch lands as well.

Sadly, we've suffered other regressions in the meantime (we're at 14 now), probably as a result of not dropping the expected count earlier. So I'll just obsolete the other patch here.