942311 - Correct from int32x4 to uint32x4

Status: RESOLVED WONTFIX

(Core :: JavaScript Engine, defect)

Description

[Niko Matsakis [:nmatsakis]]

Somewhat embarassing, but when implementing the proposed SIMD types I had the mistaken impression we wanted int32x4, when in fact we want uint32x4. This should be corrected.

Comment 1

[Niko Matsakis [:nmatsakis]]

Attachment: Bug942311.diff

Comment 2

[John McCutchan]

Hi,

The type is actually int32x4. There was some waffling but its been fixed to int32x4.

Comment 3

[haitao]

I should have mentioned the design document I sent to you was a little out of data so that you could save time for this patch. Sorry about that. The document was written in September, after that:
  1) Float32x4Array and Int32x4Array was defined in John's proposal.
  2) uint32x4 is renamed to int32x4.
  3) SIMD.add and SIMD.addu32 are changed to SIMD.float32x4.add and SIMD.int32x4.add.
As those changes does not affect the engine implementation too much, I did not update the document.

I am rebasing with V8 master, after that, I could send out a code review request to Google V8 team so that you could look at that for a reference implementation, at least, at API level.

Comment 4

[Till Schneidereit [:till]]

Comment on attachment 8337034 [details] [diff] [review]
Bug942311.diff

Canceling review based on comments 2 and 3

Comment 5

[Niko Matsakis [:nmatsakis]]

Huh. OK. The strawman http://wiki.ecmascript.org/doku.php?id=strawman:simd_number is out of date, in that case.

Comment 6

[haitao]

Here is the V8 SIMD implementation URL: https://codereview.chromium.org/90643003/.

Comment 7

[Niko Matsakis [:nmatsakis]]

Closing because it seems like I was mistaken and code is correct as is.