Closed Bug 942337 Opened 6 years ago Closed 6 years ago

Modify Contacts App so Scrollable Area is in a single layer

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect, P1)

ARM
Gonk (Firefox OS)
defect

Tracking

(Not tracked)

RESOLVED FIXED
1.2 C6(Dec6)

People

(Reporter: mchang, Assigned: mchang)

References

Details

(Keywords: perf, Whiteboard: [c=handeye p=3 s= u=])

Attachments

(1 file)

No description provided.
Blocks: 942333
Attached patch animate.patchSplinter Review
Contacts list and the profile detail both keep active layers with this patch. Only bug is when scrolling to the top / bottom of a profile detail, the whole screen repaints. This occurs with and without this patch, may be related to bug 901964. Please see video attached. 

Any ideas what could cause that final repaint?
Attachment #8337157 - Flags: feedback?(bgirard)
Comment on attachment 8337157 [details] [diff] [review]
animate.patch

Looks great
Attachment #8337157 - Flags: feedback?(bgirard) → review+
Cant this be r+ by a contacts peer?
Sure but gal give us the go ahead to review and land these. This provide no functional change (except a stacking context which these elements would have anyways). It's just a hint to the engine. There really isn't much to review since this property doesn't even exist yet.
Thanks a lot Benoit, wasn't aware of this, and right, the patch is really small, please go ahead with the changes.
Landed! https://github.com/mozilla-b2g/gaia/commit/4a595d32fe329cf3265ea3c4b6a0e7787ebe1324
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.