942337 - Modify Contacts App so Scrollable Area is in a single layer

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect, P1)

Comment 1

[Mason Chang [Inactive] [:mchang]]

Attachment: animate.patch

Contacts list and the profile detail both keep active layers with this patch. Only bug is when scrolling to the top / bottom of a profile detail, the whole screen repaints. This occurs with and without this patch, may be related to bug 901964. Please see video attached. 

Any ideas what could cause that final repaint?

Comment 2

[Mason Chang [Inactive] [:mchang]]

Video on dropbox: https://www.dropbox.com/s/a6w9si2o42a32al/Video%20Nov%2022%2C%205%2003%2001%20PM.mov

Comment 3

[Benoit Girard (:BenWa)]

Comment on attachment 8337157 [details] [diff] [review]
animate.patch

Looks great

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Cant this be r+ by a contacts peer?

Comment 5

[Benoit Girard (:BenWa)]

Sure but gal give us the go ahead to review and land these. This provide no functional change (except a stacking context which these elements would have anyways). It's just a hint to the engine. There really isn't much to review since this property doesn't even exist yet.

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Thanks a lot Benoit, wasn't aware of this, and right, the patch is really small, please go ahead with the changes.

Comment 7

[Mason Chang [Inactive] [:mchang]]

https://github.com/mozilla-b2g/gaia/pull/14271

Comment 8

[Mason Chang [Inactive] [:mchang]]

Landed! https://github.com/mozilla-b2g/gaia/commit/4a595d32fe329cf3265ea3c4b6a0e7787ebe1324