Closed Bug 942376 Opened 7 years ago Closed 7 years ago

Make "quit" and "terminate" print a message indicating they were called, in more-deterministic builds

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla28
Tracking Status
firefox28 --- fixed

People

(Reporter: gkw, Assigned: jandem)

Details

Attachments

(1 file)

When jsfunfuzz generates something like this, it incorrectly thinks it has found an uncatchable-exception bug, when in fact it has only found the quit() function.

for each (let f in this) {
  try {
    f();
  }
}

It will be nice to make "quit" and "terminate" print a message indicating they were called, in more-deterministic builds.

Thanks Jesse for helping out with this. Jan, this will help the fuzzers out here - are these similar to the OOM / too-much-recursion messages printed by more-deterministic builds?
Flags: needinfo?(jdemooij)
Attached patch PatchSplinter Review
Assignee: general → jdemooij
Status: NEW → ASSIGNED
Attachment #8337677 - Flags: review?(bhackett1024)
Flags: needinfo?(jdemooij)
Attachment #8337677 - Flags: review?(bhackett1024) → review+
https://hg.mozilla.org/mozilla-central/rev/d85ff23b7d1b
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Fuzzing rev 37110b4375f0 uses this to eliminate some false positives. Thanks!
Flags: in-testsuite?
You need to log in before you can comment on or make changes to this bug.