Active Accessibility: incorrect error code return values

RESOLVED FIXED in mozilla0.9.4

Status

SeaMonkey
General
P1
normal
RESOLVED FIXED
17 years ago
14 years ago

People

(Reporter: Aaron Leventhal, Assigned: Aaron Leventhal)

Tracking

({access, sec508})

Trunk
mozilla0.9.4
x86
Windows 2000
access, sec508

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: Looking for sr=)

Attachments

(2 attachments)

(Assignee)

Description

17 years ago
On error conditions, we are returning S_FALSE.
We should be returning E_FAIL, E_NOTIMPL, E_INVALIDARG or something that will
cause the SUCCEEDED() macro to fail
(Assignee)

Updated

17 years ago
Status: NEW → ASSIGNED
Keywords: access, fcc508
Priority: -- → P1
Target Milestone: --- → mozilla0.9.4
(Assignee)

Comment 1

17 years ago
Created attachment 45028 [details] [diff] [review]
Fixes error return codes
(Assignee)

Updated

17 years ago
Whiteboard: Looking for r=/sr=
(Assignee)

Comment 2

17 years ago
Created attachment 45043 [details] [diff] [review]
Better patch. For get_accName, get_accValue etc., return S_FALSE with NULL string out params

Comment 3

17 years ago
r= jgaunt 
Whiteboard: Looking for r=/sr= → Looking for sr=

Comment 4

17 years ago
sr=waterson
(Assignee)

Comment 5

17 years ago
fix checked in
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Updated

17 years ago
Blocks: 95819
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.