Closed
Bug 942390
Opened 11 years ago
Closed 11 years ago
Differential Testing: Different output message involving __iterator__
Categories
(Core :: JavaScript Engine: JIT, defect)
Tracking
()
RESOLVED
FIXED
mozilla28
Tracking | Status | |
---|---|---|
firefox28 | --- | fixed |
People
(Reporter: gkw, Assigned: jandem)
Details
(Keywords: testcase)
Attachments
(1 file)
1.63 KB,
patch
|
bhackett1024
:
review+
|
Details | Diff | Splinter Review |
Object.defineProperty(__proto__, "__iterator__", { get: (function() { print('FOO') }) }) __proto__ = (function(){}) for (var m = 0; m < 7; ++m) { for (var a in 6) {} } when run with --fuzzing-safe --no-baseline --no-ion --no-ti, shows "FOO" 7 times in stdout, without the flag, shows "FOO" only 1 time. Tested on a 32-bit js opt threadsafe more-deterministic shell on m-c changeset f7ad046f783f. My configure flags are: LD=ld CROSS_COMPILE=1 CXX="clang++ -Qunused-arguments -arch i386" RANLIB=ranlib CC="clang -Qunused-arguments -arch i386" AS=$CC AR=ar STRIP="strip -x -S" HOST_CC="clang -Qunused-arguments" HOST_CXX="clang++ -Qunused-arguments" sh ./configure --target=i386-apple-darwin9.2.0 --enable-macos-target=10.5 --enable-optimize --disable-debug --enable-profiling --enable-gczeal --enable-debug-symbols --enable-methodjit --enable-type-inference --disable-tests --enable-more-deterministic --with-ccache --enable-threadsafe <other NSPR flags> Jan, any idea what went wrong here?
Flags: needinfo?(jdemooij)
Assignee | ||
Comment 1•11 years ago
|
||
There's an __iterator__ getter on the prototype. If we cache the iterator in the iterator cache, we don't call it. This patch makes us not cache the iterator in this case. It also fixes a typo: obj should be pobj I think.
Assignee: nobody → jdemooij
Status: NEW → ASSIGNED
Attachment #8337691 -
Flags: review?(bhackett1024)
Flags: needinfo?(jdemooij)
Updated•11 years ago
|
Attachment #8337691 -
Flags: review?(bhackett1024) → review+
Assignee | ||
Comment 2•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/4c360770998d
Comment 3•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4c360770998d
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
status-firefox28:
--- → fixed
Flags: in-testsuite?
You need to log in
before you can comment on or make changes to this bug.
Description
•