Wrong comment format and strange unicode character "fi" in shared/download/download.properties

RESOLVED FIXED in 1.3 Sprint 6 - 12/6

Status

Firefox OS
Gaia
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: flod, Assigned: flod)

Tracking

(Blocks: 1 bug)

unspecified
1.3 Sprint 6 - 12/6
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Reference changeset (bug 937116)
https://hg.mozilla.org/gaia-l10n/en-US/rev/1822cba57298

I don't think this comment format is expected in a properties file
https://github.com/mozilla-b2g/gaia/blob/master/shared/locales/download/download.en-US.properties#L37

> /*
> * File sizes
> */

For sure it causes our tools (compare-dirs) to fail

https://l10n.mozilla.org/dashboard/compare?run=355091

shared/download/download.properties
_junk_8803_1626-1648

And another strange thing in this file. Reference changeset (Bug 940291)
https://hg.mozilla.org/gaia-l10n/en-US/rev/a3f208f7c3d2

These strings use fi instead of fi in "file" 
> file_not_found_download_message = The file wasn’t found on the device
> unsupported_file_type_download_message = There isn’t an app that can open {{name}}. Would you like to save the file or delete it?
> file_open_error_download_message = There is a problem opening {{name}}. Would you like to save the file or delete it?


Is there a reason for this? CCing the author of these two patches.
(Assignee)

Comment 1

4 years ago
Created attachment 8337368 [details] [review]
Change comment format, replace file with file

Note: I don't have access to Gaia, if the patch is good I need someone to merge.
Attachment #8337368 - Flags: review?(crdlc)
(Assignee)

Updated

4 years ago
Assignee: nobody → francesco.lodolo
Blocks: 926955
Comment on attachment 8337368 [details] [review]
Change comment format, replace file with file

Thanks

Merged in master

https://github.com/mozilla-b2g/gaia/commit/3b4460c041ca98e008760783542009485e77ea96
Attachment #8337368 - Flags: review?(crdlc) → review+
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.3 Sprint 6 - 12/6
You need to log in before you can comment on or make changes to this bug.