942425 - Menu button click and drag

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Theme and Visual Design, defect, P5)

Description

[Michael Monreal [:micmon]]

On Android 4.4 "KitKat", it is possible to press the "..." menu button and drag downwards. The menu opens and you can select a menu item without taking the finger off the display. This works on all apps using stock widgets. On Firefox this is not the case, the button looks like a normal Android menu button but it does not support the new functionality.

Comment 2

[Kevin Brosnan [Ex-Mozilla]]

Ian do we want to follow the platform convention here?

Comment 3

[Ian Barlow (:ibarlow)]

We sure do :)

Comment 4

[Veeti Paananen]

Could this also be added to the tabs button so that the tab bar can be smoothly dragged up and down?

Comment 5

[Kevin Brosnan [Ex-Mozilla]]

We have bugs open for that. See bug 909434 and bug 909427.

Comment 7

[Wesley Johnston (:wesj)]

Someone pointed me to the Android implementation of this

http://androidxref.com/4.4.2_r1/xref/frameworks/base/core/java/com/android/internal/view/menu/ActionMenuPresenter.java#168
and
http://androidxref.com/4.4.2_r1/xref/frameworks/base/core/java/android/widget/ListPopupWindow.java#1176

Stealing that forwarding listener might be a simple way to start on this if someone wanted.

Comment 8

[microrffr]

found some more things that might help

http://developer.android.com/reference/android/widget/PopupMenu.html#getDragToOpenListener%28%29
this method gives you a ForwardingListener instance for a PopupMenu. v19 and up.

http://developer.android.com/reference/android/support/v4/widget/PopupMenuCompat.html#getDragToOpenListener%28java.lang.Object%29
this support library method calls the above for v19 and returns null for older versions.

dunno if Firefox uses PopupMenu though.

Comment 9

[Firefox Bug Husbandry Bot]

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

Comment 10

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.